Merge pull request #4551 from william2958/will/subspace-patch-4

[rush] Fix rush build for subspaces

Author: octogonz

common/changes/@microsoft/rush/will-subspace-patch-4_2024-02-27-22-23.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix an issue where, when the experimental subspaces feature was enabled, the lockfile validation would check irrelevant subspaces",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}

libraries/rush-lib/src/logic/ProjectChangeAnalyzer.ts

@@ -409,27 +409,27 @@ export class ProjectChangeAnalyzer {
         const additionalFilesToHash: string[] = [];
 
         if (this._rushConfiguration.packageManager === 'pnpm') {
-          const absoluteFilePathsToCheck: string[] = [];
-
-          for (const project of this._rushConfiguration.projects) {
-            const projectShrinkwrapFilePath: string =
-              BaseProjectShrinkwrapFile.getFilePathForProject(project);
-            absoluteFilePathsToCheck.push(projectShrinkwrapFilePath);
-            const relativeProjectShrinkwrapFilePath: string = Path.convertToSlashes(
-              path.relative(rootDir, projectShrinkwrapFilePath)
-            );
-
-            additionalFilesToHash.push(relativeProjectShrinkwrapFilePath);
-          }
-
-          await Async.forEachAsync(absoluteFilePathsToCheck, async (filePath: string) => {
-            if (!(await FileSystem.existsAsync(filePath))) {
-              throw new Error(
-                `A project dependency file (${filePath}) is missing. You may need to run ` +
-                  '"rush install" or "rush update".'
+          await Async.forEachAsync(
+            this._rushConfiguration.projects,
+            async (project: RushConfigurationProject) => {
+              const projectShrinkwrapFilePath: string =
+                BaseProjectShrinkwrapFile.getFilePathForProject(project);
+              if (!(await FileSystem.existsAsync(projectShrinkwrapFilePath))) {
+                // Missing shrinkwrap of subspace project is allowed because subspace projects can be partial installed
+                if (this._rushConfiguration.subspacesFeatureEnabled) {
+                  return;
+                }
+                throw new Error(
+                  `A project dependency file (${projectShrinkwrapFilePath}) is missing. You may need to run ` +
+                    '"rush install" or "rush update".'
+                );
+              }
+              const relativeProjectShrinkwrapFilePath: string = Path.convertToSlashes(
+                path.relative(rootDir, projectShrinkwrapFilePath)
               );
+              additionalFilesToHash.push(relativeProjectShrinkwrapFilePath);
             }
-          });
+          );
         }
 
         const hashes: Map<string, string> = await getRepoStateAsync(rootDir, additionalFilesToHash, gitPath);