Skip to content

Ignore failing error code from VS Code #8872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Conversation

sean-mcmanus
Copy link
Contributor

@michelleangela Does this seem okay or did you have any better ideas? I think it's more important that the test be passing by default so we can tell if there's a regression.

@sean-mcmanus sean-mcmanus requested review from michelleangela and a team February 16, 2022 02:42
@michelleangela
Copy link
Contributor

If the error is only from VS Code's extension host and not from the test results, then it is okay to ignore errors from VS Code.

@sean-mcmanus sean-mcmanus merged commit 4972002 into main Feb 16, 2022
@sean-mcmanus sean-mcmanus deleted the seanmcm/getErrorInfo branch February 16, 2022 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants