Reduce default C++ inlay hint font size to match VS and potentially reduce confusion #9480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaulPerez1
reviewed
Jun 20, 2022
RaulPerez1
approved these changes
Jun 20, 2022
bobbrow
reviewed
Jun 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smaller font size makes it more obvious that the inlay hint is not actual editor text, and hopefully users will realize that the type data shown is the complete type data (existing type data should be ignored) and not intended to be mentally combined with the existing type data on the left, e.g. in the example below, it's not a pointer to a const, but a const pointer to a non-const int:
This doesn't affect inlay hints for other languages.
UPDATE: Size 11 seemed slightly too small and the VS UI is in flux, so it seems better to go with 12, which matches the 90% used by editor.codeLensFontSize in VS Code.