Handle invalid kernels / kernel launch fails in native notebooks (#13627)

Mac failure is not a test failure, but a VS Code CI download issue, tests passed locally for me.

Author: IanMatthewHuff

news/2 Fixes/13409.md

@@ -0,0 +1 @@
+Native notebook launch doesn't hang if the kernel does not start, and notifies the user of the failure. Also does not show the first cell as executing until the kernel is actually started and connected.

src/client/datascience/jupyter/kernels/kernel.ts

@@ -13,7 +13,6 @@ import {
     Event,
     EventEmitter,
     NotebookCell,
-    NotebookCellRunState,
     NotebookDocument,
     Uri
 } from 'vscode';
@@ -82,8 +81,8 @@ export class Kernel implements IKernel {
         private readonly launchTimeout: number,
         commandManager: ICommandManager,
         interpreterService: IInterpreterService,
-        errorHandler: IDataScienceErrorHandler,
-        private readonly contentProvider: INotebookContentProvider,
+        private readonly errorHandler: IDataScienceErrorHandler,
+        contentProvider: INotebookContentProvider,
         editorProvider: INotebookEditorProvider,
         private readonly kernelProvider: IKernelProvider,
         private readonly kernelSelectionUsage: IKernelSelectionUsage,
@@ -101,13 +100,6 @@ export class Kernel implements IKernel {
         );
     }
     public async executeCell(cell: NotebookCell): Promise<void> {
-        // Update cell to running state if cell has any code
-        if (cell.document.getText().trim().length > 0) {
-            cell.metadata.runState = NotebookCellRunState.Running;
-            this.contentProvider.notifyChangesToDocument(cell.notebook);
-        }
-
-        // Then actually start.
         await this.start({ disableUI: false, token: this.startCancellation.token });
         await this.kernelExecution.executeCell(cell);
     }
@@ -146,7 +138,12 @@ export class Kernel implements IKernel {
 
             this._notebookPromise
                 .then((nb) => (this.kernelExecution.notebook = this.notebook = nb))
-                .catch((ex) => traceError('failed to create INotebook in kernel', ex));
+                .catch((ex) => {
+                    traceError('failed to create INotebook in kernel', ex);
+                    this._notebookPromise = undefined;
+                    this.startCancellation.cancel();
+                    this.errorHandler.handleError(ex).ignoreErrors(); // Just a notification, so don't await this
+                });
             await this._notebookPromise;
             await this.initializeAfterStart();
         }

src/client/datascience/jupyter/kernels/kernelProvider.ts

@@ -29,7 +29,6 @@ export class KernelProvider implements IKernelProvider {
         @inject(IDataScienceErrorHandler) private readonly errorHandler: IDataScienceErrorHandler,
         @inject(INotebookContentProvider) private readonly contentProvider: INotebookContentProvider,
         @inject(INotebookEditorProvider) private readonly editorProvider: INotebookEditorProvider,
-
         @inject(KernelSelector) private readonly kernelSelectionUsage: IKernelSelectionUsage,
         @inject(IApplicationShell) private readonly appShell: IApplicationShell
     ) {}