Skip to content

Commit 047d7b3

Browse files
committed
Use clone deep and assume it's a full interpreter
1 parent bdd5326 commit 047d7b3

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

src/client/datascience/jupyter/liveshare/hostJupyterServer.ts

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
'use strict';
44
import '../../../common/extensions';
55

6+
// tslint:disable-next-line: no-require-imports
7+
import cloneDeep = require('lodash/cloneDeep');
68
import * as os from 'os';
79
import * as vscode from 'vscode';
810
import { CancellationToken } from 'vscode-jsonrpc';
@@ -22,8 +24,7 @@ import {
2224
} from '../../../common/types';
2325
import { createDeferred } from '../../../common/utils/async';
2426
import * as localize from '../../../common/utils/localize';
25-
import { Architecture } from '../../../common/utils/platform';
26-
import { IInterpreterService, InterpreterType } from '../../../interpreter/contracts';
27+
import { IInterpreterService, PythonInterpreter } from '../../../interpreter/contracts';
2728
import { IServiceContainer } from '../../../ioc/types';
2829
import { Identifiers, LiveShare, LiveShareCommands, RegExpValues } from '../../constants';
2930
import {
@@ -307,15 +308,7 @@ export class HostJupyterServer extends LiveShareParticipantHost(JupyterServerBas
307308

308309
// For the interpreter, make sure to select the one matching the kernel.
309310
launchInfo.interpreter = kernelInfoToUse.metadata?.interpreter?.path
310-
? {
311-
path: kernelInfoToUse.metadata.interpreter.path, // This is really the only thing that matters
312-
sysVersion: kernelInfoToUse.metadata.interpreter.sysVersion ?? '',
313-
architecture: kernelInfoToUse.metadata.interpreter.architecture ?? Architecture.Unknown,
314-
sysPrefix: kernelInfoToUse.metadata.interpreter.sysPrefix ?? '',
315-
type: kernelInfoToUse.metadata.interpreter.type ?? InterpreterType.Unknown,
316-
displayName: kernelInfoToUse.metadata.interpreter.displayName,
317-
envName: kernelInfoToUse.metadata.interpreter.envName
318-
}
311+
? (cloneDeep(kernelInfoToUse.metadata.interpreter) as PythonInterpreter)
319312
: resourceInterpreter;
320313
changedKernel = true;
321314
}

0 commit comments

Comments
 (0)