add the ip argument of jupyter server for k8s container (#9977)

tom-shan · web-flow · commit 05622347de88 · 2020-02-07T08:59:01.000-08:00
fix https://github.com/microsoft/vscode-python/issues/9976
diff --git a/news/2 Fixes/9976.md b/news/2 Fixes/9976.md
@@ -0,0 +1 @@
+add --ip=127.0.0.1 argument of jupyter server when running in k8s container
diff --git a/src/client/datascience/jupyter/notebookStarter.ts b/src/client/datascience/jupyter/notebookStarter.ts
@@ -211,7 +211,7 @@ export class NotebookStarter implements Disposable {
         // Check for a docker situation.
         try {
             const cgroup = await this.fileSystem.readFile('/proc/self/cgroup').catch(() => '');
-            if (!cgroup.includes('docker')) {
+            if (!cgroup.includes('docker') && !cgroup.includes('kubepods')) {
                 return args;
             }
             // We definitely need an ip address.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+add --ip=127.0.0.1 argument of jupyter server when running in k8s container`
Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ export class NotebookStarter implements Disposable {`
`211`	`211`	`// Check for a docker situation.`
`212`	`212`	`try {`
`213`	`213`	`const cgroup = await this.fileSystem.readFile('/proc/self/cgroup').catch(() => '');`
`214`		`- if (!cgroup.includes('docker')) {`
	`214`	`+ if (!cgroup.includes('docker') && !cgroup.includes('kubepods')) {`
`215`	`215`	`return args;`
`216`	`216`	`}`
`217`	`217`	`// We definitely need an ip address.`