Skip to content

Commit 0889962

Browse files
rchiodoDavid Kutugata
andauthored
Port start page to release (#12365)
* start page experiment and fixes (#12339) * move EnableStartPage enum to groups.ts * - remove the command from the experiment - fix the start page not loading when you go back to a priviews version and then updating again - update some labels in the start page - update the sample notebook to include run by line - the sample notebook now has a title - updated the images from the sample notebook * oops * oops * -add messages to open folder and workspace -add telemetry to measure if the webview error happens -give space between bullet points -add link to enable experiments to the sample notebook -get the release notes from a different file -fix bullet points in the sample notebook -sample notebook now opens with a counter in the title * fix a unit test * final changes * final final changes * final^3 changes * removed run by line from the sample notebook * Fixup after merge Co-authored-by: David Kutugata <[email protected]>
1 parent 6fcd5d3 commit 0889962

30 files changed

+384
-548
lines changed

StartPageReleaseNotes.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Added a start page for the extension. Launched in experimental mode such that it opens to new users or when there is a new release. It can be disabled with the setting 'Python: Show Start Page' and it can be opened at any time with the command 'Python: Open Start Page'.
2+
Removed `python.jediEnabled` setting in favor of `python.languageServer`. Instead of `"python.jediEnabled": true` please use `"python.languageServer": "Jedi"`.
3+
Made the variable explorer in the Notebook editor resizable.

images/dataviewer.gif

47.7 KB
Loading

images/kernelchange.gif

347 KB
Loading

images/plotviewer.gif

119 KB
Loading

images/remoteserver.gif

106 KB
Loading

images/runbyline.gif

302 KB
Loading

images/savetopythonfile.png

20.3 KB
Loading

images/variableexplorer.png

-149 KB
Loading

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,8 +1114,7 @@
11141114
{
11151115
"command": "python.startPage.open",
11161116
"title": "%python.command.python.startPage.open.title%",
1117-
"category": "Python",
1118-
"when": "python.datascience.startpageenabled"
1117+
"category": "Python"
11191118
},
11201119
{
11211120
"command": "python.datascience.runtoline",

package.nls.json

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -495,16 +495,18 @@
495495
"StartPage.getStarted": "Python - Get Started",
496496
"StartPage.pythonExtensionTitle": "Python Extension",
497497
"StartPage.createJupyterNotebook": "Create a Jupyter Notebook",
498-
"StartPage.notebookDescription": "- Use \"<div class=\"italics\">Shift + Command + P</div> \" to open the <div class=\"link\" role=\"button\" onclick={0}>Command Palette</div><br />- Type \"<div class=\"link italics\" role=\"button\" onclick={1}>Create New Blank Jupyter Notebook</div> \"<br />- Explore our <div class=\"link\" role=\"button\" onclick={2}>sample notebook</div> to learn about notebook features",
498+
"StartPage.notebookDescription": "- Run \"<div class=\"link italics\" role=\"button\" onclick={0}>Create New Blank Jupyter Notebook</div>\" in the Command Palette (<div class=\"italics\">Shift + Command + P</div>)<br />- Explore our <div class=\"link\" role=\"button\" onclick={1}>sample notebook</div> to learn about notebook features",
499499
"StartPage.createAPythonFile": "Create a Python File",
500-
"StartPage.pythonFileDescription": "- Create a new file and use the .py extension<br />- <div class=\"link\" role=\"button\" onclick={0}>Open a file or workspace</div> to continue work",
501-
"StartPage.openInteractiveWindow": "Open the Interactive Window",
500+
"StartPage.pythonFileDescription": "- Create a <div class=\"link\" role=\"button\" onclick={0}>new file</div> with a .py extension",
501+
"StartPage.openInteractiveWindow": "Use the Interactive Window to develop Python Scripts",
502502
"StartPage.interactiveWindowDesc": "- You can create cells on a Python file by typing \"#%%\" <br /> - Use \"<div class=\"italics\">Shift + Enter</div> \" to run a cell, the output will be shown in the interactive window",
503503
"StartPage.releaseNotes": "Take a look at our <a class=\"link\" href={0}>Release Notes</a> to learn more about the latest features",
504504
"StartPage.tutorialAndDoc": "Explore more features in our <a class=\"link\" href={0}>Tutorials</a> or check <a class=\"link\" href={1}>Documentation</a> for tips and troubleshooting.",
505505
"StartPage.dontShowAgain": "Don't show this page again",
506506
"StartPage.helloWorld": "Hello world",
507-
"StartPage.sampleNotebook": "Welcome_To_VSCode_Notebooks.ipynb",
507+
"StartPage.sampleNotebook": "Notebooks intro",
508+
"StartPage.openFolder": "Open a Folder or Workspace",
509+
"StartPage.folderDesc": "- Open a <div class=\"link\" role=\"button\" onclick={0}>Folder</div><br /> - Open a <div class=\"link\" role=\"button\" onclick={1}>Workspace</div>",
508510
"DataScience.libraryRequiredToLaunchJupyterKernelNotInstalledInterpreter": "{0} requires {1} to be installed.",
509511
"DataScience.runByLine": "Run by line (F10)",
510512
"DataScience.stopRunByLine": "Stop",

pythonFiles/Notebooks intro.ipynb

Lines changed: 203 additions & 0 deletions
Large diffs are not rendered by default.

pythonFiles/Welcome_To_VSCode_Notebooks.ipynb

Lines changed: 0 additions & 192 deletions
This file was deleted.

src/client/common/application/commands.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,8 @@ export interface ICommandNameArgumentTypeMapping extends ICommandNameWithoutArgu
8888
['vscode.openWith']: [Uri, string];
8989
['workbench.action.quickOpen']: [string];
9090
['workbench.extensions.installExtension']: [Uri | 'ms-python.python'];
91+
['workbench.action.files.openFolder']: [];
92+
['workbench.action.openWorkspace']: [];
9193
['setContext']: [string, boolean];
9294
['python.reloadVSCode']: [string];
9395
['revealLine']: [{ lineNumber: number; at: 'top' | 'center' | 'bottom' }];

src/client/common/experiments/groups.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,3 +110,8 @@ export enum CustomEditorSupport {
110110
control = 'CustomEditorSupport - control',
111111
experiment = 'CustomEditorSupport - experiment'
112112
}
113+
114+
// Experiment to turn on the start page
115+
export enum EnableStartPage {
116+
experiment = 'EnableStartPage'
117+
}

0 commit comments

Comments
 (0)