Skip to content

Commit 1fd5509

Browse files
Update version and change log (#10662)
* Update version and change log * Fix flakey file system tests (#10541) Co-authored-by: Rich Chiodo <[email protected]>
1 parent 9005608 commit 1fd5509

File tree

5 files changed

+23
-18
lines changed

5 files changed

+23
-18
lines changed

CHANGELOG.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Changelog
22

3-
## 2020.3.0-rc (9 March 2020)
3+
## 2020.3.0 (19 March 2020)
44

55
### Enhancements
66

@@ -114,6 +114,8 @@
114114
([#10311](https://github.com/Microsoft/vscode-python/issues/10311))
115115
1. When you install missing dependencies for Jupyter successfully in an active interpreter also set that interpreter as the Jupyter selected interpreter.
116116
([#10359](https://github.com/Microsoft/vscode-python/issues/10359))
117+
1. Ensure default `host` is not set, if `connect` or `listen` settings are available.
118+
([#10597](https://github.com/Microsoft/vscode-python/issues/10597))
117119

118120
### Code Health
119121

@@ -135,8 +137,6 @@
135137
([#10182](https://github.com/Microsoft/vscode-python/issues/10182))
136138
1. Use debugpy in the core extension instead of ptvsd.
137139
([#10184](https://github.com/Microsoft/vscode-python/issues/10184))
138-
1. Remove UI Tests.
139-
([#10192](https://github.com/Microsoft/vscode-python/issues/10192))
140140
1. Add telemetry for imports in notebooks.
141141
([#10209](https://github.com/Microsoft/vscode-python/issues/10209))
142142
1. Update data science component to use `debugpy`.

news/2 Fixes/10597.md

Lines changed: 0 additions & 1 deletion
This file was deleted.

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "python",
33
"displayName": "Python",
44
"description": "Linting, Debugging (multi-threaded, remote), Intellisense, Jupyter Notebooks, code formatting, refactoring, unit tests, snippets, and more.",
5-
"version": "2020.3.0-rc",
5+
"version": "2020.3.0",
66
"languageServerVersion": "0.5.30",
77
"publisher": "ms-python",
88
"author": {

src/test/common/platform/filesystem.functional.test.ts

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ import * as fs from 'fs-extra';
88
import { convertStat, FileSystem, FileSystemUtils, RawFileSystem } from '../../../client/common/platform/fileSystem';
99
import { FileSystemPaths, FileSystemPathUtils } from '../../../client/common/platform/fs-paths';
1010
import { FileType } from '../../../client/common/platform/types';
11-
import { sleep } from '../../../client/common/utils/async';
11+
import { createDeferred, sleep } from '../../../client/common/utils/async';
12+
import { noop } from '../../../client/common/utils/misc';
1213
import {
1314
assertDoesNotExist,
1415
assertFileText,
@@ -267,13 +268,24 @@ suite('FileSystem - raw', () => {
267268
}
268269
});
269270

271+
async function writeToStream(filename: string, write: (str: fs.WriteStream) => void) {
272+
const closeDeferred = createDeferred();
273+
const stream = fileSystem.createWriteStream(filename);
274+
stream.on('close', () => closeDeferred.resolve());
275+
write(stream);
276+
stream.end();
277+
stream.close();
278+
stream.destroy();
279+
await closeDeferred.promise;
280+
return stream;
281+
}
282+
270283
test('returns the correct WriteStream', async () => {
271284
const filename = await fix.resolve('x/y/z/spam.py');
272285
const expected = fs.createWriteStream(filename);
273286
expected.destroy();
274287

275-
const stream = fileSystem.createWriteStream(filename);
276-
stream.destroy();
288+
const stream = await writeToStream(filename, noop);
277289

278290
expect(stream.path).to.deep.equal(expected.path);
279291
});
@@ -283,9 +295,7 @@ suite('FileSystem - raw', () => {
283295
await assertDoesNotExist(filename);
284296
const data = 'line1\nline2\n';
285297

286-
const stream = fileSystem.createWriteStream(filename);
287-
stream.write(data);
288-
stream.destroy();
298+
await writeToStream(filename, s => s.write(data));
289299

290300
await assertFileText(filename, data);
291301
});
@@ -294,9 +304,7 @@ suite('FileSystem - raw', () => {
294304
const filename = await fix.resolve('x/y/z/spam.py');
295305
const data = '... 😁 ...';
296306

297-
const stream = fileSystem.createWriteStream(filename);
298-
stream.write(data);
299-
stream.destroy();
307+
await writeToStream(filename, s => s.write(data));
300308

301309
await assertFileText(filename, data);
302310
});
@@ -305,9 +313,7 @@ suite('FileSystem - raw', () => {
305313
const filename = await fix.createFile('x/y/z/spam.py', '...');
306314
const data = 'line1\nline2\n';
307315

308-
const stream = fileSystem.createWriteStream(filename);
309-
stream.write(data);
310-
stream.destroy();
316+
await writeToStream(filename, s => s.write(data));
311317

312318
await assertFileText(filename, data);
313319
});

0 commit comments

Comments
 (0)