More logging for kernelspec problems (#10132)

* More logging for kernelspec problems

* Actually capture the exception on the new code

* Not actually using output if first exception still there.

* Actually only return output on one of the expected calls.

* Fix nightly flake

Author: rchiodo

src/client/datascience/jupyter/interpreter/jupyterCommand.ts

@@ -203,6 +203,7 @@ export class InterpreterJupyterKernelSpecCommand extends InterpreterJupyterComma
 
         const defaultAction = () => {
             if (exception) {
+                traceError(`Exception attempting to enumerate kernelspecs: `, exception);
                 throw exception;
             }
             return output;
@@ -218,10 +219,12 @@ export class InterpreterJupyterKernelSpecCommand extends InterpreterJupyterComma
         try {
             if (args.join(' ').toLowerCase() === 'list --json') {
                 // Try getting kernels using python script, if that fails (even if there's output in stderr) rethrow original exception.
-                return this.getKernelSpecList(interpreter, options);
+                output = await this.getKernelSpecList(interpreter, options);
+                return output;
             } else if (args.join(' ').toLowerCase() === '--version') {
                 // Try getting kernelspec version using python script, if that fails (even if there's output in stderr) rethrow original exception.
-                return this.getKernelSpecVersion(interpreter, options);
+                output = await this.getKernelSpecVersion(interpreter, options);
+                return output;
             }
         } catch (innerEx) {
             traceError('Failed to get a list of the kernelspec using python script', innerEx);

src/client/datascience/jupyter/interpreter/jupyterInterpreterDependencyService.ts

@@ -8,6 +8,7 @@ import { CancellationToken } from 'vscode';
 import { IApplicationShell } from '../../../common/application/types';
 import { Cancellation, createPromiseFromCancellation, wrapCancellationTokens } from '../../../common/cancellation';
 import { ProductNames } from '../../../common/installer/productNames';
+import { traceError } from '../../../common/logger';
 import { IInstaller, InstallerResponse, Product } from '../../../common/types';
 import { Common, DataScience } from '../../../common/utils/localize';
 import { noop } from '../../../common/utils/misc';
@@ -275,7 +276,8 @@ export class JupyterInterpreterDependencyService {
         return command
             .exec(['--version'], { throwOnStdErr: true })
             .then(() => true)
-            .catch(() => {
+            .catch(e => {
+                traceError(`Kernel spec not found: `, e);
                 sendTelemetryEvent(Telemetry.KernelSpecNotFound);
                 return false;
             });

src/test/datascience/variableexplorer.functional.test.tsx

@@ -184,7 +184,16 @@ myDict = {'a': 1}`;
                 { name: 'myDict', value: "{'a': 1}", supportsDataExplorer: true, type: 'dict', size: 54, shape: '', count: 0, truncated: false },
                 { name: 'myList', value: '[1, 2, 3]', supportsDataExplorer: true, type: 'list', size: 54, shape: '', count: 0, truncated: false },
                 // Set can vary between python versions, so just don't both to check the value, just see that we got it
-                { name: 'mySet', value: undefined, supportsDataExplorer: true, type: 'set', size: 54, shape: '', count: 0, truncated: false }
+                {
+                    name: 'mySet',
+                    value: undefined,
+                    supportsDataExplorer: false,
+                    type: 'set',
+                    size: 54,
+                    shape: '',
+                    count: 0,
+                    truncated: false
+                }
             ];
             verifyVariables(wrapper, targetVariables);
         },