Skip to content

Commit 2a41042

Browse files
author
Kartik Raj
authored
Fix link to create a new Jupyter notebook in Python start page (#15670)
1 parent f85d591 commit 2a41042

File tree

7 files changed

+7
-9
lines changed

7 files changed

+7
-9
lines changed

news/2 Fixes/15621.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix link to create a new Jupyter notebook in Python start page.

package.nls.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@
213213
"StartPage.getStarted": "Python - Get Started",
214214
"StartPage.pythonExtensionTitle": "Python Extension",
215215
"StartPage.createJupyterNotebook": "Create a Jupyter Notebook",
216-
"StartPage.notebookDescription": "- Run \"<div class=\"link italics\" role=\"button\" onclick={0}>Create New Blank Jupyter Notebook</div>\" in the Command Palette (<div class=\"italics\">Shift + Command + P</div>)<br />- Explore our <div class=\"link\" role=\"button\" onclick={1}>sample notebook</div> to learn about notebook features",
216+
"StartPage.notebookDescription": "- Run \"<div class=\"link italics\" role=\"button\" onclick={0}>Create New Blank Notebook</div>\" in the Command Palette (<div class=\"italics\">Shift + Command + P</div>)<br />- Explore our <div class=\"link\" role=\"button\" onclick={1}>sample notebook</div> to learn about notebook features",
217217
"StartPage.createAPythonFile": "Create a Python File",
218218
"StartPage.pythonFileDescription": "- Create a <div class=\"link\" role=\"button\" onclick={0}>new file</div> with a .py extension",
219219
"StartPage.openInteractiveWindow": "Use the Interactive Window to develop Python Scripts",

package.nls.zh-cn.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@
206206
"StartPage.getStarted": "Python - 开始",
207207
"StartPage.pythonExtensionTitle": "Python 扩展",
208208
"StartPage.createJupyterNotebook": "创建 Jupyter 笔记本",
209-
"StartPage.notebookDescription": "- 在命令面板 (<div class=\"italics\">Shift + Command + P</div>) 中运行 \"<div class=\"link italics\" role=\"button\" onclick={0}>创建新的 Jupyter 笔记本</div>\" <br />- 探索 <div class=\"link\" role=\"button\" onclick={1}>示例笔记本</div> 来了解笔记本的功能",
209+
"StartPage.notebookDescription": "- 在命令面板 (<div class=\"italics\">Shift + Command + P</div>) 中运行 \"<div class=\"link italics\" role=\"button\" onclick={0}>创建新的 笔记本</div>\" <br />- 探索 <div class=\"link\" role=\"button\" onclick={1}>示例笔记本</div> 来了解笔记本的功能",
210210
"StartPage.createAPythonFile": "创建 Python 文件",
211211
"StartPage.pythonFileDescription": "- 创建以 .py 为扩展名的<div class=\"link\" role=\"button\" onclick={0}>新文件</div>",
212212
"StartPage.openInteractiveWindow": "使用交互式窗口开发 Python 脚本",

pythonFiles/Notebooks intro.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"metadata": {},
1313
"source": [
1414
"1. Open the command palette with the shortcut: `Ctrl/Command` + `Shift` + `P`\r\n",
15-
"2. Search for the command `Create New Blank Jupyter Notebook`"
15+
"2. Search for the command `Create New Blank Notebook`"
1616
]
1717
},
1818
{

src/client/common/startPage/startPage.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,10 +172,7 @@ export class StartPage extends WebviewPanelHost<IStartPageMapping>
172172
sendTelemetryEvent(Telemetry.StartPageOpenCommandPaletteWithOpenNBSelected);
173173
this.setTelemetryFlags();
174174

175-
await this.commandManager.executeCommand(
176-
'workbench.action.quickOpen',
177-
'>Create New Blank Jupyter Notebook',
178-
);
175+
await this.commandManager.executeCommand('workbench.action.quickOpen', '>Create New Blank Notebook');
179176
break;
180177
case StartPageMessages.OpenSampleNotebook:
181178
sendTelemetryEvent(Telemetry.StartPageOpenSampleNotebook);

src/client/common/utils/localize.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ export namespace StartPage {
411411
export const createJupyterNotebook = localize('StartPage.createJupyterNotebook', 'Create a Jupyter Notebook');
412412
export const notebookDescription = localize(
413413
'StartPage.notebookDescription',
414-
'- Run "<div class="link italics" role="button" onclick={0}>Create New Blank Jupyter Notebook</div>" in the Command Palette (<div class="italics">Shift + Command + P</div>)<br />- Explore our <div class="link" role="button" onclick={1}>sample notebook</div> to learn about notebook features',
414+
'- Run "<div class="link italics" role="button" onclick={0}>Create New Blank Notebook</div>" in the Command Palette (<div class="italics">Shift + Command + P</div>)<br />- Explore our <div class="link" role="button" onclick={1}>sample notebook</div> to learn about notebook features',
415415
);
416416
export const createAPythonFile = localize('StartPage.createAPythonFile', 'Create a Python File');
417417
export const pythonFileDescription = localize(

src/startPage-ui/startPage/startPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ export class StartPage extends React.Component<IStartPageProps> implements IMess
185185
dangerouslySetInnerHTML={{
186186
__html: getLocString(
187187
'StartPage.notebookDescription',
188-
'- Run "<div class="link italics" role="button" onclick={0}>Create New Blank Jupyter Notebook</div>" in the Command Palette (<div class="italics">Shift + Command + P</div>)<br />- Explore our <div class="link" role="button" onclick={1}>sample notebook</div> to learn about notebook features',
188+
'- Run "<div class="link italics" role="button" onclick={0}>Create New Blank Notebook</div>" in the Command Palette (<div class="italics">Shift + Command + P</div>)<br />- Explore our <div class="link" role="button" onclick={1}>sample notebook</div> to learn about notebook features',
189189
).format('openCommandPaletteWithSelection()', 'openSampleNotebook()'),
190190
}}
191191
/>

0 commit comments

Comments
 (0)