Skip to content

Commit 2c2b7e1

Browse files
Cherry pick from main (#14644)
* Update shipped wheels version (#14615) * Update shipped wheels version * News item * Remove redundant files (#14620) * Add extension dependencies at build time (#14636) * Use Node 12.15 in Insiders and Release GitHub Actions (#14641) * Use Node 12.15 on all Insiders and Release GitHub Actions jobs (#14642) Co-authored-by: Joyce Er <[email protected]>
1 parent 1b41519 commit 2c2b7e1

File tree

14 files changed

+60
-175
lines changed

14 files changed

+60
-175
lines changed

.github/actions/build-vsix/action.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,8 @@ runs:
3030
- run: npm run updateBuildNumber -- --buildNumber $GITHUB_RUN_ID
3131
shell: bash
3232

33+
- run: npm run addExtensionDependencies
34+
shell: bash
35+
3336
- run: npm run package
3437
shell: bash

.github/workflows/insiders.yml

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ on:
66
- main
77

88
env:
9+
NODE_VERSION: 12.15.0
910
PYTHON_VERSION: 3.9
1011
MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it haven't already.
1112
# Key for the cache created at the end of the the 'Cache ./pythonFiles/lib/python' step.
@@ -25,6 +26,11 @@ jobs:
2526
- name: Checkout
2627
uses: actions/checkout@v2
2728

29+
- name: Use Node ${{env.NODE_VERSION}}
30+
uses: actions/[email protected]
31+
with:
32+
node-version: ${{env.NODE_VERSION}}
33+
2834
- name: Use Python ${{env.PYTHON_VERSION}}
2935
uses: actions/setup-python@v2
3036
with:
@@ -55,6 +61,11 @@ jobs:
5561
- name: Checkout
5662
uses: actions/checkout@v2
5763

64+
- name: Use Node ${{env.NODE_VERSION}}
65+
uses: actions/[email protected]
66+
with:
67+
node-version: ${{env.NODE_VERSION}}
68+
5869
- name: Install dependencies (npm ci)
5970
run: npm ci --prefer-offline
6071

@@ -118,6 +129,11 @@ jobs:
118129
with:
119130
path: ${{env.special-working-directory-relative}}
120131

132+
- name: Use Node ${{env.NODE_VERSION}}
133+
uses: actions/[email protected]
134+
with:
135+
node-version: ${{env.NODE_VERSION}}
136+
121137
- name: Install dependencies (npm ci)
122138
run: npm ci
123139

@@ -319,6 +335,11 @@ jobs:
319335
- name: Checkout
320336
uses: actions/checkout@v2
321337

338+
- name: Use Node ${{env.NODE_VERSION}}
339+
uses: actions/[email protected]
340+
with:
341+
node-version: ${{env.NODE_VERSION}}
342+
322343
- name: Use Python ${{matrix.python}}
323344
uses: actions/setup-python@v2
324345
with:
@@ -390,6 +411,11 @@ jobs:
390411
- name: Checkout
391412
uses: actions/checkout@v2
392413

414+
- name: Use Node ${{env.NODE_VERSION}}
415+
uses: actions/[email protected]
416+
with:
417+
node-version: ${{env.NODE_VERSION}}
418+
393419
- name: Use Python ${{matrix.python}}
394420
uses: actions/setup-python@v2
395421
with:

.github/workflows/release.yml

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99

1010
env:
1111
PYTHON_VERSION: 3.8
12+
NODE_VERSION: 12.15.0
1213
MOCHA_REPORTER_JUNIT: false # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it hasn't already.
1314
# Key for the cache created at the end of the the 'Cache ./pythonFiles/lib/python' step.
1415
CACHE_PYTHONFILES: cache-pvsc-pythonFiles
@@ -27,6 +28,11 @@ jobs:
2728
- name: Checkout
2829
uses: actions/checkout@v2
2930

31+
- name: Use Node ${{env.NODE_VERSION}}
32+
uses: actions/[email protected]
33+
with:
34+
node-version: ${{env.NODE_VERSION}}
35+
3036
- name: Use Python ${{env.PYTHON_VERSION}}
3137
uses: actions/setup-python@v2
3238
with:
@@ -59,6 +65,11 @@ jobs:
5965
- name: Checkout
6066
uses: actions/checkout@v2
6167

68+
- name: Use Node ${{env.NODE_VERSION}}
69+
uses: actions/[email protected]
70+
with:
71+
node-version: ${{env.NODE_VERSION}}
72+
6273
- name: Install dependencies (npm ci)
6374
run: npm ci --prefer-offline
6475

@@ -105,6 +116,11 @@ jobs:
105116
with:
106117
path: ${{env.special-working-directory-relative}}
107118

119+
- name: Use Node ${{env.NODE_VERSION}}
120+
uses: actions/[email protected]
121+
with:
122+
node-version: ${{env.NODE_VERSION}}
123+
108124
- name: Install dependencies (npm ci)
109125
run: npm ci
110126

@@ -296,6 +312,11 @@ jobs:
296312
- name: Checkout
297313
uses: actions/checkout@v2
298314

315+
- name: Use Node ${{env.NODE_VERSION}}
316+
uses: actions/[email protected]
317+
with:
318+
node-version: ${{env.NODE_VERSION}}
319+
299320
- name: Use Python ${{matrix.python}}
300321
uses: actions/setup-python@v2
301322
with:
@@ -367,6 +388,11 @@ jobs:
367388
- name: Checkout
368389
uses: actions/checkout@v2
369390

391+
- name: Use Node ${{env.NODE_VERSION}}
392+
uses: actions/[email protected]
393+
with:
394+
node-version: ${{env.NODE_VERSION}}
395+
370396
- name: Use Python ${{matrix.python}}
371397
uses: actions/setup-python@v2
372398
with:

news/1 Enhancements/14614.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Update shipped debugger wheels to python 3.8.

pythonFiles/install_debugpy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
EXTENSION_ROOT = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
1010
DEBUGGER_DEST = os.path.join(EXTENSION_ROOT, "pythonFiles", "lib", "python")
1111
DEBUGGER_PACKAGE = "debugpy"
12-
DEBUGGER_PYTHON_VERSIONS = ("cp37",)
12+
DEBUGGER_PYTHON_VERSIONS = ("cp38",)
1313

1414

1515
def _contains(s, parts=()):

src/client/activation/languageClientMiddleware.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ import { IFileSystem } from '../common/platform/types';
3939
import { IConfigurationService, IDisposableRegistry, IExperimentsManager, IExtensions } from '../common/types';
4040
import { isThenable } from '../common/utils/async';
4141
import { StopWatch } from '../common/utils/stopWatch';
42-
import { NotebookMiddlewareAddon } from '../datascience/languageserver/notebookMiddlewareAddon';
4342
import { IServiceContainer } from '../ioc/types';
43+
import { NotebookMiddlewareAddon } from '../jupyter/languageserver/notebookMiddlewareAddon';
4444
import { sendTelemetryEvent } from '../telemetry';
4545
import { EventName } from '../telemetry/constants';
4646
import { LanguageServerType } from './types';

src/client/api.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ import { Event, Uri } from 'vscode';
88
import { isTestExecution } from './common/constants';
99
import { traceError } from './common/logger';
1010
import { IConfigurationService, Resource } from './common/types';
11-
import { IDataViewerDataProvider, IJupyterUriProvider } from './datascience/types';
1211
import { getDebugpyLauncherArgs, getDebugpyPackagePath } from './debugger/extension/adapter/remoteLaunchers';
1312
import { IInterpreterService } from './interpreter/contracts';
1413
import { IServiceContainer, IServiceManager } from './ioc/types';
1514
import { JupyterExtensionIntegration } from './jupyter/jupyterIntegration';
15+
import { IDataViewerDataProvider, IJupyterUriProvider } from './jupyter/types';
1616

1717
/*
1818
* Do not introduce any breaking changes to this API.

src/client/datascience/api/jupyterIntegration.ts

Lines changed: 0 additions & 142 deletions
This file was deleted.

src/client/jupyter/jupyterIntegration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ import {
2222
Resource
2323
} from '../common/types';
2424
import { isResource } from '../common/utils/misc';
25-
import { IDataViewerDataProvider, IJupyterUriProvider } from '../datascience/types';
2625
import { getDebugpyPackagePath } from '../debugger/extension/adapter/remoteLaunchers';
2726
import { IEnvironmentActivationService } from '../interpreter/activation/types';
2827
import { IInterpreterQuickPickItem, IInterpreterSelector } from '../interpreter/configuration/types';
2928
import { IInterpreterService } from '../interpreter/contracts';
3029
import { IWindowsStoreInterpreter } from '../interpreter/locators/types';
3130
import { WindowsStoreInterpreter } from '../pythonEnvironments/discovery/locators/services/windowsStoreInterpreter';
3231
import { PythonEnvironment } from '../pythonEnvironments/info';
32+
import { IDataViewerDataProvider, IJupyterUriProvider } from './types';
3333

3434
export interface ILanguageServer extends Disposable {
3535
readonly connection: ILanguageServerConnection;
File renamed without changes.

src/test/datascience/mockJupyterExtensionIntegration.ts

Lines changed: 0 additions & 29 deletions
This file was deleted.

0 commit comments

Comments
 (0)