Create an HTTP server to serve up our react UI (#8931)

* Preliminary work

* Fix border

* Fix linter

* Get basic react code loading

* Get web view to work
Add settings
Hardcode working dir for now. It's used for file returns

* Switching idea and fixed settings

* Dynamic port number

* Force localhost

* Change parsing of settings

* Move settings and json init into messages so can not send so much in initial HTTP request

* Update docker container settings

* Load index bundle with http instead of inline

* Add token for authentication

* Fix style to eliminate padding

* Update debugging comments

* Move web panel server into code instead of using node

* Undo unneeded node js debugging configs

* Add unit tests for the server

* Fix webpanel mock to work with a promise
Fix install test to actually verify results

* Fix settings to be there for tests
Fix intellisense tests to clean up the suggestion box

* Fix more functional tests

* Change webServer default to off unless insiders

* Add news entry

* Use portfinder for webpanel tests.

* Add issue to comment instead of TODO

* Fix unit tests

* Attempt to get vsix to build

* Different way to ignore warnings

* Change error to be easier to fix later.

* Try warning in different spot

* Code review feedback

* Change to not using a stream for the main index.html

Author: rchiodo

.devcontainer/Dockerfile

@@ -5,30 +5,49 @@
 
 FROM node:8
 
-# Configure apt
+# Avoid warnings by switching to noninteractive
 ENV DEBIAN_FRONTEND=noninteractive
-RUN apt-get update \
-    && apt-get -y install --no-install-recommends apt-utils 2>&1
 
-# Verify git and needed tools are installed
-RUN apt-get install -y git procps
+# The node image comes with a base non-root 'node' user which this Dockerfile
+# gives sudo access. However, for Linux, this user's GID/UID must match your local
+# user UID/GID to avoid permission issues with bind mounts. Update USER_UID / USER_GID 
+# if yours is not 1000. See https://aka.ms/vscode-remote/containers/non-root-user.
+ARG USER_UID=1000
+ARG USER_GID=$USER_UID
 
-# Remove outdated yarn from /opt and install via package 
-# so it can be easily updated via apt-get upgrade yarn
-RUN rm -rf /opt/yarn-* \
+# Configure apt and install packages
+RUN apt-get update \
+    && apt-get -y install --no-install-recommends apt-utils dialog 2>&1 \
+    #
+    # Verify git and needed tools are installed
+    && apt-get -y install git iproute2 procps \    
+    #
+    # Remove outdated yarn from /opt and install via package 
+    # so it can be easily updated via apt-get upgrade yarn
+    && rm -rf /opt/yarn-* \
     && rm -f /usr/local/bin/yarn \
     && rm -f /usr/local/bin/yarnpkg \
     && apt-get install -y curl apt-transport-https lsb-release \
     && curl -sS https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/pubkey.gpg | apt-key add - 2>/dev/null \
     && echo "deb https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/ stable main" | tee /etc/apt/sources.list.d/yarn.list \
     && apt-get update \
-    && apt-get -y install --no-install-recommends yarn
-
-# Install tslint and typescript
-RUN npm install -g tslint typescript
-
-# Clean up
-RUN apt-get autoremove -y \
+    && apt-get -y install --no-install-recommends yarn \
+    #
+    # Install tslint and typescript globally
+    && npm install -g tslint typescript \
+    #
+    # [Optional] Update a non-root user to match UID/GID - see https://aka.ms/vscode-remote/containers/non-root-user.
+    && if [ "$USER_GID" != "1000" ]; then groupmod node --gid $USER_GID; fi \
+    && if [ "$USER_UID" != "1000" ]; then usermod --uid $USER_UID node; fi \
+    # [Optional] Add add sudo support for non-root user
+    && apt-get install -y sudo \
+    && echo node ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/node \
+    && chmod 0440 /etc/sudoers.d/node \
+    #
+    # Clean up
+    && apt-get autoremove -y \
     && apt-get clean -y \
     && rm -rf /var/lib/apt/lists/*
-ENV DEBIAN_FRONTEND=dialog
+
+# Switch back to dialog for any ad-hoc use of apt-get
+ENV DEBIAN_FRONTEND=

.devcontainer/devcontainer.json

@@ -1,7 +1,27 @@
-// See https://aka.ms/vscode-remote/devcontainer.json for format details.
+// For format details, see https://aka.ms/vscode-remote/devcontainer.json or the definition README at
+// https://github.com/microsoft/vscode-dev-containers/tree/master/containers/typescript-node-8
 {
 	"name": "Node.js 8 & TypeScript",
 	"dockerFile": "Dockerfile",
+
+	// Use 'settings' to set *default* container specific settings.json values on container create. 
+	// You can edit these settings after create using File > Preferences > Settings > Remote.
+	"settings": { 
+		"terminal.integrated.shell.linux": "/bin/bash"
+	},
+
+	// Uncomment the next line if you want to publish any ports.
+	// "appPort": [],
+	
+	// Uncomment the next line to run commands after the container is created.
+	// "postCreateCommand": "yarn install",
+
+	// Uncomment the next line to use a non-root user. On Linux, this will prevent
+	// new files getting created as root, but you may need to update the USER_UID
+	// and USER_GID in .devcontainer/Dockerfile to match your user if not 1000.
+	// "runArgs": [ "-u", "node" ],
+
+	// Add the IDs of extensions you want installed when the container is created in the array below.
 	"extensions": [
 		"ms-vscode.vscode-typescript-tslint-plugin"
 	]

build/webpack/common.js

@@ -31,7 +31,11 @@ exports.nodeModulesToExternalize = [
     'crypto-js',
     'fontkit',
     'linebreak',
-    'png-js'
+    'png-js',
+    '@koa/cors',
+    'koa',
+    'koa-compress',
+    'koa-logger'
 ];
 exports.nodeModulesToReplacePaths = [
     ...exports.nodeModulesToExternalize

build/webpack/common.ts

@@ -33,7 +33,11 @@ export const nodeModulesToExternalize = [
     'crypto-js',
     'fontkit',
     'linebreak',
-    'png-js'
+    'png-js',
+    '@koa/cors',
+    'koa',
+    'koa-compress',
+    'koa-logger'
 ];
 
 export const nodeModulesToReplacePaths = [

gulpfile.js

@@ -179,7 +179,7 @@ async function buildWebPack(webpackConfigName, args) {
         throw new Error(`Errors in ${webpackConfigName}, \n${warnings.join(', ')}\n\n${stdOut}`);
     }
     if (warnings.length > 0) {
-        throw new Error(`Warnings in ${webpackConfigName}, \n\n${stdOut}`);
+        throw new Error(`Warnings in ${webpackConfigName}, Check gulpfile.js to see if the warning should be allowed., \n\n${stdOut}`);
     }
 }
 function getAllowedWarningsForWebPack(buildConfig) {
@@ -196,15 +196,17 @@ function getAllowedWarningsForWebPack(buildConfig) {
                 'WARNING in ./node_modules/ws/lib/Validation.js',
                 'WARNING in ./node_modules/ws/lib/validation.js',
                 'WARNING in ./node_modules/@jupyterlab/services/node_modules/ws/lib/buffer-util.js',
-                'WARNING in ./node_modules/@jupyterlab/services/node_modules/ws/lib/validation.js'
+                'WARNING in ./node_modules/@jupyterlab/services/node_modules/ws/lib/validation.js',
+                'WARNING in ./node_modules/any-promise/register.js'
             ];
         case 'extension':
             return [
                 'WARNING in ./node_modules/encoding/lib/iconv-loader.js',
                 'WARNING in ./node_modules/ws/lib/BufferUtil.js',
                 'WARNING in ./node_modules/ws/lib/buffer-util.js',
                 'WARNING in ./node_modules/ws/lib/Validation.js',
-                'WARNING in ./node_modules/ws/lib/validation.js'
+                'WARNING in ./node_modules/ws/lib/validation.js',
+                'WARNING in ./node_modules/any-promise/register.js'
             ];
         case 'debugAdapter':
             return ['WARNING in ./node_modules/vscode-uri/lib/index.js'];

news/2 Fixes/7704.md

@@ -0,0 +1 @@
+Support local images in markdown and output for notebooks.