Skip to content

Commit 348e85a

Browse files
fix for button backgrounds (#10234)
1 parent 97f9fd5 commit 348e85a

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

news/2 Fixes/10154.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Correct image backgrounds for notebook editor.

src/datascience-ui/native-editor/nativeEditor.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@
293293

294294
.native-button {
295295
margin-top: 3px;
296-
background: var(--override-background, var(--vscode-editor-background));
296+
background: transparent;
297297
z-index: 10;
298298
}
299299

src/datascience-ui/react-common/imageButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class ImageButton extends React.Component<IImageButtonProps> {
2222

2323
public render() {
2424
const classNames = `image-button image-button-${this.props.baseTheme} ${this.props.hidden ? 'hide' : ''} ${
25-
this.props.className
25+
this.props.className ? this.props.className : ''
2626
}`;
2727
const innerFilter = this.props.disabled ? 'image-button-inner-disabled-filter' : '';
2828
const ariaDisabled = this.props.disabled ? 'true' : 'false';

0 commit comments

Comments
 (0)