Skip to content

Commit 374198b

Browse files
authored
Send telemetry for notebook trust prompt selections (#12964)
* Send telemetry for notebook trust prompt * Send telemetry when prompt is shown
1 parent c217914 commit 374198b

File tree

3 files changed

+23
-2
lines changed

3 files changed

+23
-2
lines changed

src/client/datascience/constants.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,11 @@ export enum Telemetry {
368368
RunByLineStart = 'DATASCIENCE.RUN_BY_LINE',
369369
RunByLineStep = 'DATASCIENCE.RUN_BY_LINE_STEP',
370370
RunByLineStop = 'DATASCIENCE.RUN_BY_LINE_STOP',
371-
RunByLineVariableHover = 'DATASCIENCE.RUN_BY_LINE_VARIABLE_HOVER'
371+
RunByLineVariableHover = 'DATASCIENCE.RUN_BY_LINE_VARIABLE_HOVER',
372+
TrustAllNotebooks = 'DATASCIENCE.TRUST_ALL_NOTEBOOKS',
373+
TrustNotebook = 'DATASCIENCE.TRUST_NOTEBOOK',
374+
DoNotTrustNotebook = 'DATASCIENCE.DO_NOT_TRUST_NOTEBOOK',
375+
NotebookTrustPromptShown = 'DATASCIENCE.NOTEBOOK_TRUST_PROMPT_SHOWN'
372376
}
373377

374378
export enum NativeKeyboardCommandTelemetry {

src/client/datascience/interactive-ipynb/trustCommandHandler.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ import '../../common/extensions';
1313
import { IDisposableRegistry, IExperimentService } from '../../common/types';
1414
import { swallowExceptions } from '../../common/utils/decorators';
1515
import { DataScience } from '../../common/utils/localize';
16-
import { Commands } from '../constants';
16+
import { sendTelemetryEvent } from '../../telemetry';
17+
import { Commands, Telemetry } from '../constants';
1718
import { INotebookStorageProvider } from '../interactive-ipynb/notebookStorageProvider';
1819
import { INotebookEditorProvider, ITrustService } from '../types';
1920

@@ -57,10 +58,12 @@ export class TrustCommandHandler implements IExtensionSingleActivationService {
5758
DataScience.doNotTrustNotebook(),
5859
DataScience.trustAllNotebooks()
5960
);
61+
sendTelemetryEvent(Telemetry.NotebookTrustPromptShown);
6062

6163
switch (selection) {
6264
case DataScience.trustAllNotebooks():
6365
commands.executeCommand('workbench.action.openSettings', 'python.dataScience.alwaysTrustNotebooks');
66+
sendTelemetryEvent(Telemetry.TrustAllNotebooks);
6467
break;
6568
case DataScience.trustNotebook():
6669
// Update model trust
@@ -73,6 +76,10 @@ export class TrustCommandHandler implements IExtensionSingleActivationService {
7376
});
7477
const contents = model.getContent();
7578
await this.trustService.trustNotebook(model.file, contents);
79+
sendTelemetryEvent(Telemetry.TrustNotebook);
80+
break;
81+
case DataScience.doNotTrustNotebook():
82+
sendTelemetryEvent(Telemetry.DoNotTrustNotebook);
7683
break;
7784
default:
7885
break;

src/client/telemetry/index.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2192,10 +2192,20 @@ export interface IEventNamePropertyMapping {
21922192
[Telemetry.StartPageOpenFileBrowser]: never | undefined;
21932193
[Telemetry.StartPageOpenFolder]: never | undefined;
21942194
[Telemetry.StartPageOpenWorkspace]: never | undefined;
2195+
2196+
// Run by line events
21952197
[Telemetry.RunByLineStart]: never | undefined;
21962198
[Telemetry.RunByLineStep]: never | undefined;
21972199
[Telemetry.RunByLineStop]: never | undefined;
21982200
[Telemetry.RunByLineVariableHover]: never | undefined;
2201+
2202+
// Trusted notebooks events
2203+
[Telemetry.NotebookTrustPromptShown]: never | undefined;
2204+
[Telemetry.TrustNotebook]: never | undefined;
2205+
[Telemetry.TrustAllNotebooks]: never | undefined;
2206+
[Telemetry.DoNotTrustNotebook]: never | undefined;
2207+
2208+
// Native notebooks events
21992209
[VSCodeNativeTelemetry.AddCell]: never | undefined;
22002210
[VSCodeNativeTelemetry.DeleteCell]: never | undefined;
22012211
[VSCodeNativeTelemetry.MoveCell]: never | undefined;

0 commit comments

Comments
 (0)