Skip to content

Commit 3be03b0

Browse files
Porting K8 fix to release (#9987)
1 parent 4946e5c commit 3be03b0

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@
4646
([#9701](https://github.com/Microsoft/vscode-python/issues/9701))
4747

4848
### Fixes
49+
1. add --ip=127.0.0.1 argument of jupyter server when running in k8s container
50+
([#9976](https://github.com/Microsoft/vscode-python/issues/9976))
4951
1. Correct the server and kernel text for when not connected to a server.
5052
([#9933](https://github.com/Microsoft/vscode-python/issues/9933))
5153
1. Make sure to clear variable list on restart kernel.

src/client/datascience/jupyter/notebookStarter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ export class NotebookStarter implements Disposable {
211211
// Check for a docker situation.
212212
try {
213213
const cgroup = await this.fileSystem.readFile('/proc/self/cgroup').catch(() => '');
214-
if (!cgroup.includes('docker')) {
214+
if (!cgroup.includes('docker') && !cgroup.includes('kubepods')) {
215215
return args;
216216
}
217217
// We definitely need an ip address.

0 commit comments

Comments
 (0)