Fix bug with autoselection (#11185)

Author: Kartik Raj

src/client/interpreter/autoSelection/index.ts

@@ -135,15 +135,6 @@ export class InterpreterAutoSelectionService implements IInterpreterAutoSelectio
         return this.globallyPreferredInterpreter.value;
     }
     public async setWorkspaceInterpreter(resource: Uri, interpreter: PythonInterpreter | undefined) {
-        // We can only update the stored interpreter once we have done the necessary
-        // work of auto selecting the interpreters.
-        if (
-            !this.autoSelectedWorkspacePromises.has(this.getWorkspacePathKey(resource)) ||
-            !this.autoSelectedWorkspacePromises.get(this.getWorkspacePathKey(resource))!.completed
-        ) {
-            return;
-        }
-
         await this.storeAutoSelectedInterpreter(resource, interpreter);
     }
     public async setGlobalInterpreter(interpreter: PythonInterpreter) {

src/test/interpreters/autoSelection/index.unit.test.ts

@@ -319,26 +319,6 @@ suite('Interpreters - Auto Selection', () => {
         expect(selectedInterpreter).to.deep.equal(interpreterInfo);
         expect(eventFired).to.deep.equal(false, 'event fired');
     });
-    test('Storing workspace interpreter info in state store should fail', async () => {
-        const pythonPath = 'Hello World';
-        const interpreterInfo = { path: pythonPath } as any;
-        const resource = Uri.parse('one');
-        when(
-            stateFactory.createGlobalPersistentState<PythonInterpreter | undefined>(
-                preferredGlobalInterpreter,
-                undefined
-            )
-        ).thenReturn(instance(state));
-        when(workspaceService.getWorkspaceFolder(resource)).thenReturn({ name: '', index: 0, uri: resource });
-        when(workspaceService.getWorkspaceFolderIdentifier(anything(), anything())).thenReturn('');
-
-        await autoSelectionService.initializeStore(undefined);
-        await autoSelectionService.setWorkspaceInterpreter(resource, interpreterInfo);
-        const selectedInterpreter = autoSelectionService.getAutoSelectedInterpreter(resource);
-
-        verify(state.updateValue(interpreterInfo)).never();
-        expect(selectedInterpreter ? selectedInterpreter : undefined).to.deep.equal(undefined, 'not undefined');
-    });
     test('Store workspace interpreter info in state store', async () => {
         const pythonPath = 'Hello World';
         const interpreterInfo = { path: pythonPath } as any;