Skip to content

Commit 5c3433b

Browse files
authored
Remove auto save telemetry. Not using it for anything. (#8948)
1 parent e4d0e64 commit 5c3433b

File tree

4 files changed

+1
-8
lines changed

4 files changed

+1
-8
lines changed

news/3 Code Health/8906.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Remove unused auto-save-enabled telemetry.

src/client/datascience/constants.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ export enum Telemetry {
135135
/**
136136
* Whether auto save feature in VS Code is enabled or not.
137137
*/
138-
AutoSaveEnabled = 'DATASCIENCE.AUTO_SAVE_ENABLED',
139138
ShowHistoryPane = 'DATASCIENCE.SHOW_HISTORY_PANE',
140139
ExpandAll = 'DATASCIENCE.EXPAND_ALL',
141140
CollapseAll = 'DATASCIENCE.COLLAPSE_ALL',

src/client/datascience/datascience.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ export class DataScience implements IDataScience {
9595

9696
// Send telemetry for all of our settings
9797
this.sendSettingsTelemetry().ignoreErrors();
98-
this.sendStartupTelemetry();
9998
}
10099

101100
public async dispose() {
@@ -622,11 +621,6 @@ export class DataScience implements IDataScience {
622621
sendTelemetryEvent(Telemetry.DataScienceSettings, 0, resultSettings);
623622
}
624623
}
625-
@swallowExceptions('Error in sending DS Startup telemetry')
626-
private sendStartupTelemetry() {
627-
const filesConfig = this.workspace.getConfiguration('files');
628-
sendTelemetryEvent(Telemetry.AutoSaveEnabled, undefined, { enabled: filesConfig.get('autoSave', 'off') !== 'off' });
629-
}
630624

631625
private async createNewNotebook(): Promise<void> {
632626
await this.notebookProvider.createNew();

src/client/telemetry/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1467,7 +1467,6 @@ export interface IEventNamePropertyMapping {
14671467
[Telemetry.ScrolledToCell]: never | undefined;
14681468
[Telemetry.CellCount]: { count: number };
14691469
[Telemetry.Save]: never | undefined;
1470-
[Telemetry.AutoSaveEnabled]: { enabled: boolean };
14711470
[Telemetry.SelfCertsMessageClose]: never | undefined;
14721471
[Telemetry.SelfCertsMessageEnabled]: never | undefined;
14731472
[Telemetry.SelectJupyterURI]: never | undefined;

0 commit comments

Comments
 (0)