Fixes a few linter and compiler issues (#10616)

Author: DonJayamanne

package.datascience-ui.dependencies.json

@@ -172,6 +172,7 @@
     "remark-parse",
     "repeat-string",
     "roughjs-es5",
+    "rxjs",
     "scheduler",
     "semiotic-mark",
     "semiotic",

src/datascience-ui/interactive-common/cellOutput.tsx

@@ -302,7 +302,6 @@ export class CellOutput extends React.Component<ICellOutputProps> {
             // Render the outputs
             return this.renderOutputs(this.getCodeCell().outputs, trim);
         }
-        console.log(this.renderOutputs);
         return [];
     };
 

src/datascience-ui/ipywidgets/classicComm.ts

@@ -4,6 +4,7 @@
 'use strict';
 
 import { Kernel, KernelMessage } from '@jupyterlab/services';
+import { JSONObject, JSONValue } from '@phosphor/coreutils';
 import * as uuid from 'uuid/v4';
 import { createDeferred } from '../../client/common/utils/async';
 import { noop } from '../../client/common/utils/misc';
@@ -23,13 +24,11 @@ export class ClassicComm implements Kernel.IComm {
         private readonly messageSender: IMessageSender,
         private readonly callbackManager: ClassicCommShellCallbackManager
     ) {}
-    // tslint:disable-next-line: no-any
     public open(
-        data?: any,
-        metadata?: any,
+        data?: JSONValue,
+        metadata?: JSONValue,
         buffers?: (ArrayBuffer | ArrayBufferView)[] | undefined
     ): Kernel.IShellFuture {
-        // tslint:disable-next-line: no-console
         const requestId = uuid();
         const commId: string = this.commId;
         const deferred = createDeferred<KernelMessage.IShellMessage | undefined>();
@@ -69,8 +68,8 @@ export class ClassicComm implements Kernel.IComm {
     }
     // tslint:disable-next-line: no-any
     public close(
-        _data?: any,
-        _metadata?: any,
+        _data?: JSONValue,
+        _metadata?: JSONObject,
         _buffers?: (ArrayBuffer | ArrayBufferView)[] | undefined
     ): Kernel.IShellFuture {
         this.registeredFutures.forEach(item => this.callbackManager.unregisterFuture(item));
@@ -81,12 +80,11 @@ export class ClassicComm implements Kernel.IComm {
     }
     // tslint:disable-next-line: no-any
     public send(
-        data: any,
-        metadata?: any,
+        data: JSONValue,
+        metadata?: JSONObject,
         buffers?: (ArrayBuffer | ArrayBufferView)[] | undefined,
         disposeOnDone?: boolean | undefined
     ): Kernel.IShellFuture {
-        // tslint:disable-next-line: no-console
         const requestId = uuid();
         const commId: string = this.commId;
         const deferred = createDeferred<KernelMessage.IShellMessage | undefined>();

src/datascience-ui/ipywidgets/container.tsx

@@ -10,8 +10,8 @@ import { IInteractiveWindowMapping } from '../../client/datascience/interactive-
 import { IStore } from '../interactive-common/redux/store';
 import { WidgetManager } from './manager';
 
-// tslint:disable-next-line: no-any
 type Props = {
+    // tslint:disable-next-line: no-any
     messages: Observable<{ type: string; payload?: any }>;
     sendMessage<M extends IInteractiveWindowMapping, T extends keyof M>(type: T, payload?: M[T]): void;
 };

src/datascience-ui/ipywidgets/manager.ts

@@ -164,7 +164,6 @@ export class WidgetManager implements IIPyWidgetManager, IMessageSender {
         this.proxyKernel.initialize();
     }
     private restoreBuffers(msg: KernelMessage.IIOPubMessage) {
-        debugger;
         if (!msg || !Array.isArray(msg.buffers) || msg.buffers.length === 0) {
             return;
         }