Skip to content

Commit 70c3298

Browse files
karthiknadigMikhail Arkhipov
andauthored
Contains cherry picks, version updates, change log updates (#12983)
* Update version and change log * Improve detection when LS is fully loaded for IntelliCode (#12853) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Wait for client ready * Handle async dispose * Fix the date Co-authored-by: Mikhail Arkhipov <[email protected]>
1 parent 40d5dcd commit 70c3298

File tree

6 files changed

+17
-11
lines changed

6 files changed

+17
-11
lines changed

CHANGELOG.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Changelog
22

3-
## 2020.7.0-rc (8 July 2020)
3+
## 2020.7.0 (15 July 2020)
44

55
### Enhancements
66

@@ -9,7 +9,8 @@
99
([#9679](https://github.com/Microsoft/vscode-python/issues/9679))
1010
1. Added "argsExpansion" to debugpy launch.json schema.
1111
([#11678](https://github.com/Microsoft/vscode-python/issues/11678))
12-
1. The extension will now automatically load if a `pyproject.toml` file is present in the workspace root directory. (@BrandonLWhite)
12+
1. The extension will now automatically load if a `pyproject.toml` file is present in the workspace root directory.
13+
(thanks [Brandon White](https://github.com/BrandonLWhite))
1314
([#12056](https://github.com/Microsoft/vscode-python/issues/12056))
1415
1. Add ability to check and update whether a notebook is trusted.
1516
([#12146](https://github.com/Microsoft/vscode-python/issues/12146))
@@ -29,14 +30,11 @@
2930
([#12611](https://github.com/Microsoft/vscode-python/issues/12611))
3031
1. Include the JUPYTER_PATH environment variable when searching the disk for kernels.
3132
([#12694](https://github.com/Microsoft/vscode-python/issues/12694))
32-
1. Added exporting to python, HTML and PDF from the interative window.
33+
1. Added exporting to python, HTML and PDF from the interactive window.
3334
([#12732](https://github.com/Microsoft/vscode-python/issues/12732))
3435
1. Show a prompt asking user to upgrade Code runner to new version to keep using it when in Deprecate PythonPath experiment.
3536
([#12764](https://github.com/Microsoft/vscode-python/issues/12764))
3637
1. Opening notebooks in the preview Notebook editor for [Visual Studio Code Insiders](https://code.visualstudio.com/insiders/).
37-
* Install Python extension in the latest [Visual Studio Code Insiders](https://code.visualstudio.com/insiders/).
38-
* Wait for `Python Extension` to get activated (e.g. open a `Python` file).
39-
* Right click on an `*.ipynb (Jupyter Notebook)` file and select `Open in preview Notebook Editor`.
4038
([#10496](https://github.com/Microsoft/vscode-python/issues/10496))
4139

4240
### Fixes
@@ -45,6 +43,8 @@
4543
([#10579](https://github.com/Microsoft/vscode-python/issues/10579))
4644
1. Provided a method for external partners to participate in jupyter server URI picking/authentication.
4745
([#10993](https://github.com/Microsoft/vscode-python/issues/10993))
46+
1. Check for hideFromUser before activating current terminal.
47+
([#11122](https://github.com/Microsoft/vscode-python/issues/11122))
4848
1. In Markdown cells, turn HTML links to markdown links so that nteract renders them.
4949
([#11254](https://github.com/Microsoft/vscode-python/issues/11254))
5050
1. Prevent incorrect ipywidget display (double plots) due to synchronization issues.

news/2 Fixes/11122.md

Lines changed: 0 additions & 1 deletion
This file was deleted.

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "python",
33
"displayName": "Python",
44
"description": "Linting, Debugging (multi-threaded, remote), Intellisense, Jupyter Notebooks, code formatting, refactoring, unit tests, snippets, and more.",
5-
"version": "2020.7.0-rc",
5+
"version": "2020.7.0",
66
"featureFlags": {
77
"usingNewInterpreterStorage": true
88
},

src/client/activation/languageServer/languageServerProxy.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,13 @@ export class DotNetLanguageServerProxy implements ILanguageServerProxy {
102102
}
103103
@captureTelemetry(EventName.PYTHON_LANGUAGE_SERVER_READY, undefined, true)
104104
protected async serverReady(): Promise<void> {
105-
while (this.languageClient && !this.languageClient!.initializeResult) {
105+
// languageClient can be disposed in awaits.
106+
while (this.languageClient && !this.languageClient.initializeResult) {
106107
await sleep(100);
107108
}
109+
if (this.languageClient) {
110+
await this.languageClient.onReady();
111+
}
108112
this.startupCompleted.resolve();
109113
}
110114
@swallowExceptions('Activating Unit Tests Manager for Language Server')

src/client/activation/node/languageServerProxy.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,12 @@ export class NodeLanguageServerProxy implements ILanguageServerProxy {
146146
NodeLanguageServerProxy.versionTelemetryProps
147147
)
148148
protected async serverReady(): Promise<void> {
149-
while (this.languageClient && !this.languageClient!.initializeResult) {
149+
while (this.languageClient && !this.languageClient.initializeResult) {
150150
await sleep(100);
151151
}
152+
if (this.languageClient) {
153+
await this.languageClient.onReady();
154+
}
152155
this.startupCompleted.resolve();
153156
}
154157

0 commit comments

Comments
 (0)