Disallow sending selection to terminal when in a notebook editor context to not mess with shift-enter execution (#14803)

IanMatthewHuff · Ian Huff · web-flow · commit 735516af0b44 · 2020-11-23T13:24:58.000-08:00
Co-authored-by: Ian Huff &lt;ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com&gt;
diff --git a/package.json b/package.json
@@ -98,7 +98,7 @@
             {
                 "command": "python.execSelectionInTerminal",
                 "key": "shift+enter",
-                "when": "editorTextFocus && editorLangId == python && !findInputFocussed && !replaceInputFocussed && !jupyter.ownsSelection"
+                "when": "editorTextFocus && editorLangId == python && !findInputFocussed && !replaceInputFocussed && !jupyter.ownsSelection && !notebookEditorFocused"
             }
         ],
         "commands": [

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@`
`98`	`98`	`{`
`99`	`99`	`"command": "python.execSelectionInTerminal",`
`100`	`100`	`"key": "shift+enter",`
`101`		`- "when": "editorTextFocus && editorLangId == python && !findInputFocussed && !replaceInputFocussed && !jupyter.ownsSelection"`
	`101`	`+ "when": "editorTextFocus && editorLangId == python && !findInputFocussed && !replaceInputFocussed && !jupyter.ownsSelection && !notebookEditorFocused"`
`102`	`102`	`}`
`103`	`103`	`],`
`104`	`104`	`"commands": [`