Code reviews

Author: Kartik Raj

src/client/pythonEnvironments/common/pythonBinariesWatcher.ts

@@ -18,8 +18,8 @@ export function watchLocationForPythonBinaries(
     const patterns = [executablePattern, `*/${executablePattern}`, `*/${binName}/${executablePattern}`];
     for (const pattern of patterns) {
         watchLocationForPattern(baseDir, pattern, (type: FileChangeType, e: string) => {
-            const isMatch = picomatch(executablePattern);
-            if (!isMatch(path.basename(e))) {
+            const regex = picomatch.toRegex(executablePattern, { nocase: getOSType() === OSType.Windows });
+            if (!regex.test(path.basename(e))) {
                 // When deleting the file for some reason path to all directories leading up to python are reported
                 // Skip those events
                 return;

src/client/pythonEnvironments/discovery/locators/services/windowsStoreLocator.ts

@@ -105,8 +105,8 @@ const windowsPythonExes = 'python3\.[0-9]\.exe';
  * @returns {boolean} : Returns true if the path matches pattern for windows python executable.
  */
 export function isWindowsStorePythonExe(interpreterPath: string): boolean {
-    const isMatch = picomatch(windowsPythonExes);
-    return isMatch(path.basename(interpreterPath));
+    const regex = picomatch.toRegex(windowsPythonExes, { nocase: true });
+    return regex.test(path.basename(interpreterPath));
 }
 
 /**