ExP telemetry fixes (#12358)

* Use extension channel instead of VS Code channel
* Use publisher.name extension id (not just name)
* Update vscode-tas-client

Author: kimadeline

package-lock.json

@@ -3118,7 +3118,7 @@
         "vscode-languageclient": "^6.2.0-next.2",
         "vscode-languageserver": "^6.2.0-next.2",
         "vscode-languageserver-protocol": "^3.16.0-next.2",
-        "vscode-tas-client": "^0.0.757",
+        "vscode-tas-client": "^0.0.864",
         "vsls": "^0.3.1291",
         "winreg": "^1.2.4",
         "winston": "^3.2.1",

package.json

@@ -9,6 +9,7 @@ import { getExperimentationService, IExperimentationService, TargetPopulation }
 import { sendTelemetryEvent } from '../../telemetry';
 import { EventName } from '../../telemetry/constants';
 import { IApplicationEnvironment } from '../application/types';
+import { PVSC_EXTENSION_ID } from '../constants';
 import { GLOBAL_MEMENTO, IConfigurationService, IExperimentService, IMemento, IPythonSettings } from '../types';
 import { ExperimentationTelemetry } from './telemetry';
 
@@ -47,7 +48,7 @@ export class ExperimentService implements IExperimentService {
 
         let targetPopulation: TargetPopulation;
 
-        if (this.appEnvironment.channel === 'insiders') {
+        if (this.appEnvironment.extensionChannel === 'insiders') {
             targetPopulation = TargetPopulation.Insiders;
         } else {
             targetPopulation = TargetPopulation.Public;
@@ -56,7 +57,7 @@ export class ExperimentService implements IExperimentService {
         const telemetryReporter = new ExperimentationTelemetry();
 
         this.experimentationService = getExperimentationService(
-            this.appEnvironment.extensionName,
+            PVSC_EXTENSION_ID,
             this.appEnvironment.packageJson.version!,
             targetPopulation,
             telemetryReporter,

src/client/common/experiments/service.ts

@@ -46,7 +46,7 @@ suite('Experimentation service', () => {
     }
 
     function configureApplicationEnvironment(channel: Channel, version: string) {
-        when(appEnvironment.channel).thenReturn(channel);
+        when(appEnvironment.extensionChannel).thenReturn(channel);
         when(appEnvironment.extensionName).thenReturn(PVSC_EXTENSION_ID_FOR_TESTS);
         when(appEnvironment.packageJson).thenReturn({ version });
     }