Skip to content

Commit 98a3e81

Browse files
committed
Skip venv tests for 2.7 and disable fail fast
1 parent d0158c3 commit 98a3e81

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ jobs:
195195
if: github.repository == 'microsoft/vscode-python'
196196
needs: [python-deps, js-ts-deps]
197197
strategy:
198+
fail-fast: false
198199
matrix:
199200
# We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used,
200201
# macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case.
@@ -381,6 +382,7 @@ jobs:
381382
- name: Run venv tests
382383
env:
383384
TEST_FILES_SUFFIX: testvirtualenvs
385+
CI_PYTHON_VERSION: ${{matrix.python}}
384386
uses: GabrielBB/[email protected]
385387
with:
386388
run: npm run testSingleWorkspace

src/test/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,11 @@ suite('Activation of Environments in Terminal', () => {
171171
expect(fileSystem.arePathsSame(content, PYTHON_PATH)).to.equal(false, 'Environment not activated');
172172
});
173173

174-
test('Should activate with venv', async () => {
174+
test('Should activate with venv', async function () {
175+
if (process.env.CI_PYTHON_VERSION && process.env.CI_PYTHON_VERSION.startsWith('2.')) {
176+
// tslint:disable-next-line: no-invalid-this
177+
this.skip();
178+
}
175179
await testActivation(envPaths.venvPath);
176180
});
177181
test('Should activate with pipenv', async () => {

0 commit comments

Comments
 (0)