Fix scrolling when don't have focus (#11246)

rchiodo · rchiodo · commit 998a1951cbc8 · 2020-04-17T17:24:12.000-07:00
diff --git a/news/2 Fixes/11238.md b/news/2 Fixes/11238.md
@@ -0,0 +1 @@
+Fix scrolling in a notebook whenever resizing or opening.
diff --git a/src/datascience-ui/react-common/monacoEditor.tsx b/src/datascience-ui/react-common/monacoEditor.tsx
@@ -551,7 +551,7 @@ export class MonacoEditor extends React.Component<IMonacoEditorProps, IMonacoEdi
 
     private scrollToCurrentPosition(_editor: monacoEditor.editor.IStandaloneCodeEditor) {
         // Unfortunately during functional tests we hack the line count and the like.
-        if (isTestExecution()) {
+        if (isTestExecution() || !this.props.hasFocus) {
             return;
         }
         // Scroll to the visible line that has our current line. Note: Visible lines are not sorted by monaco

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix scrolling in a notebook whenever resizing or opening.`
Original file line number	Diff line number	Diff line change
`@@ -551,7 +551,7 @@ export class MonacoEditor extends React.Component<IMonacoEditorProps, IMonacoEdi`
`551`	`551`
`552`	`552`	`private scrollToCurrentPosition(_editor: monacoEditor.editor.IStandaloneCodeEditor) {`
`553`	`553`	`// Unfortunately during functional tests we hack the line count and the like.`
`554`		`- if (isTestExecution()) {`
	`554`	`+ if (isTestExecution() \|\| !this.props.hasFocus) {`
`555`	`555`	`return;`
`556`	`556`	`}`
`557`	`557`	`// Scroll to the visible line that has our current line. Note: Visible lines are not sorted by monaco`