Skip to content

Commit ab63f02

Browse files
authored
Version, change log and cherrypicks for nov release (#14696)
* change log updates * Update gifs * Fix for interpreter selection (#14693) * Fix for interpreter selection * Fix linting errors * Minor tweak to property removal
1 parent 5eab81d commit ab63f02

File tree

10 files changed

+27
-17
lines changed

10 files changed

+27
-17
lines changed

CHANGELOG.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
# Changelog
22

3-
## 2020.11.0-rc (4 November 2020)
3+
## 2020.11.0 (11 November 2020)
44

55
### Enhancements
66

7-
UPDATE THIS BEFORE RELEASE
7+
1. Update shipped debugger wheels to python 3.8.
8+
([#14614](https://github.com/Microsoft/vscode-python/issues/14614))
89

910
### Fixes
1011

@@ -15,6 +16,10 @@ UPDATE THIS BEFORE RELEASE
1516
1. When sending code to the REPL, read input from `sys.stdin` instead of passing it as an argument.
1617
([#14471](https://github.com/Microsoft/vscode-python/issues/14471))
1718

19+
### Code Health
20+
21+
1. Code for Jupyter Notebooks support has been refactored into the Jupyter extension, which is now a dependency for the Python extension
22+
1823
### Thanks
1924

2025
Thanks to the following projects which we fully rely on to provide some of

images/ConfigureDebugger.gif

19.3 KB
Loading

images/ConfigureTests.gif

276 KB
Loading

images/InterpreterSelectionZoom.gif

16.4 KB
Loading

images/OpenOrCreateNotebook.gif

3.44 MB
Loading

news/1 Enhancements/14614.md

Lines changed: 0 additions & 1 deletion
This file was deleted.

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "python",
33
"displayName": "Python",
44
"description": "Linting, Debugging (multi-threaded, remote), Intellisense, Jupyter Notebooks, code formatting, refactoring, unit tests, snippets, and more.",
5-
"version": "2020.11.0-rc",
5+
"version": "2020.11.0",
66
"featureFlags": {
77
"usingNewInterpreterStorage": true
88
},

src/client/common/configSettings.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,21 @@ export class PythonSettings implements IPythonSettings {
196196
PythonSettings.pythonSettings.forEach((item) => item && item.dispose());
197197
PythonSettings.pythonSettings.clear();
198198
}
199+
200+
public static toSerializable(settings: IPythonSettings): IPythonSettings {
201+
// tslint:disable-next-line: no-any
202+
const clone: any = {};
203+
const keys = Object.entries(settings);
204+
keys.forEach((e) => {
205+
const [k, v] = e;
206+
if (!k.includes('Manager') && !k.includes('Service') && !k.includes('onDid')) {
207+
clone[k] = v;
208+
}
209+
});
210+
211+
return clone as IPythonSettings;
212+
}
213+
199214
public dispose() {
200215
// tslint:disable-next-line:no-unsafe-any
201216
this.disposables.forEach((disposable) => disposable && disposable.dispose());

src/client/common/startPage/webviewHost.ts

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import * as localize from '../utils/localize';
1515
import { DefaultTheme, Telemetry } from './constants';
1616
import { ICodeCssGenerator, IThemeFinder } from './types';
1717

18+
import { PythonSettings } from '../configSettings';
1819
import { isTestExecution } from '../constants';
1920
import { IConfigurationService, IDisposable, IPythonSettings, Resource } from '../types';
2021
import { CssMessages, IGetCssRequest, IGetMonacoThemeRequest, SharedMessages } from './messages';
@@ -104,18 +105,8 @@ export abstract class WebviewHost<IMapping> implements IDisposable {
104105
}
105106

106107
protected async generateExtraSettings(): Promise<IPythonSettings> {
107-
const resource = this.owningResource;
108-
// tslint:disable-next-line: no-any
109-
const prunedSettings = this.configService.getSettings(resource) as any;
110-
111-
// Remove keys that aren't serializable
112-
const keys = Object.keys(prunedSettings);
113-
keys.forEach((k) => {
114-
if (k.includes('Manager') || k.includes('Service') || k.includes('onDid')) {
115-
delete prunedSettings[k];
116-
}
117-
});
118-
return prunedSettings;
108+
const settings = this.configService.getSettings(this.owningResource);
109+
return PythonSettings.toSerializable(settings);
119110
}
120111

121112
protected async sendLocStrings() {

0 commit comments

Comments
 (0)