Use CommandSource as input to second call of getNamesAndValues

In the picker unit tests two calls to getNamesAndValues are used to
extract values from enums. The second call used a generic with type
'CommandSource' but as input a Type object. To be more meaningful this
has been changed to 'CommandSource' so that the test checks different
TestItem types against different command sources. Otherwise it would
test TestItem types against TestItem types.

Furthermore extracting name and value of CommandSource.commandpalette
with getNamesAndValues was not successful and returned undefined. This
has been fixed by assigning CommandSource.commandpalette directly to
commandSource.value when this command source is evaluated.

Author: Philipp Loose

src/test/testing/display/picker.unit.test.ts

@@ -16,14 +16,21 @@ import { onItemSelected, Type } from '../../../client/testing/display/picker';
 
 suite('Unit Tests - Picker (execution of commands)', () => {
     getNamesAndValues<Type>(Type).forEach(item => {
-        getNamesAndValues<CommandSource>(Type).forEach(commandSource => {
+        getNamesAndValues<CommandSource>(CommandSource).forEach(commandSource => {
             [true, false].forEach(debug => {
                 test(`Invoking command for selection ${item.name} from ${commandSource.name} (${debug ? 'Debug' : 'No debug'})`, async () => {
                     const commandManager = mock(CommandManager);
                     const workspaceUri = Uri.file(__filename);
 
                     const testFunction = 'some test Function';
-                    const selection = { type: item.value, fn: { testFunction } };
+                    // Getting the value of CommandSource.commandPalette in getNamesAndValues(CommandSource)
+                    // fails because the names and values object is build by accessing the CommandSource enum
+                    // properties by value. In case of commandpalette the property is commandPalette and the
+                    // respective value is commandpalette which do not match and thus return undefined for value.
+                    if (commandSource.name === 'commandpalette') {
+                        commandSource.value = CommandSource.commandPalette;
+                    }
+
                     onItemSelected(instance(commandManager), commandSource.value, workspaceUri, selection as any, debug);
 
                     switch (selection.type) {