Skip to content

Commit c41c08f

Browse files
authored
Unpin setup-node action (#14610)
Allows us to pick up bugfixes immediately
1 parent e33b4e2 commit c41c08f

File tree

2 files changed

+28
-37
lines changed

2 files changed

+28
-37
lines changed

.github/workflows/insiders.yml

Lines changed: 24 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ jobs:
130130
python-version: ${{matrix.python}}
131131

132132
- name: Use Node ${{env.NODE_VERSION}}
133-
uses: actions/setup-node@v2.1.1
133+
uses: actions/setup-node@v2
134134
with:
135135
node-version: ${{env.NODE_VERSION}}
136136

@@ -355,11 +355,10 @@ jobs:
355355
uses: azure/login@v1
356356
with:
357357
creds: ${{ secrets.AZURE_CREDENTIALS }}
358-
358+
359359
- name: Download JUPYTER VSIX
360360
run: az storage blob download --file ${{env.VSIX_NAME_JUPYTER}} --account-name pvsc --container-name extension-builds-jupyter --name ${{env.VSIX_NAME_JUPYTER}} --auth-mode login
361361

362-
363362
- name: Set CI_PYTHON_PATH and CI_DISABLE_AUTO_SELECTION
364363
run: |
365364
echo "CI_PYTHON_PATH=python" >> $GITHUB_ENV
@@ -421,11 +420,10 @@ jobs:
421420
uses: azure/login@v1
422421
with:
423422
creds: ${{ secrets.AZURE_CREDENTIALS }}
424-
423+
425424
- name: Download JUPYTER VSIX
426425
run: az storage blob download --file ${{env.VSIX_NAME_JUPYTER}} --account-name pvsc --container-name extension-builds-jupyter --name ${{env.VSIX_NAME_JUPYTER}} --auth-mode login
427426

428-
429427
- name: Set CI_PYTHON_PATH and CI_DISABLE_AUTO_SELECTION
430428
run: |
431429
echo "CI_PYTHON_PATH=python" >> $GITHUB_ENV
@@ -442,7 +440,7 @@ jobs:
442440
CODE_TESTS_WORKSPACE: ./src/testMultiRootWkspc/smokeTests
443441
uses: GabrielBB/[email protected]
444442
with:
445-
run: node --no-force-async-hooks-checks ./out/test/standardTest.js
443+
run: node --no-force-async-hooks-checks ./out/test/standardTest.js
446444

447445
coverage:
448446
name: Coverage reports upload
@@ -479,30 +477,25 @@ jobs:
479477
with:
480478
token: ${{ secrets.CODECOV_TOKEN }}
481479
file: ./coverage/cobertura-coverage.xml
482-
483480
# Re-enable when the Jupyter extension is available
484481
# upload:
485-
# name: Upload VSIX to Azure Blob Storage
486-
# runs-on: ubuntu-latest
487-
# if: github.repository == 'microsoft/vscode-python'
488-
# needs: [tests, smoke-tests, build-vsix]
489-
# env:
490-
# BLOB_CONTAINER_NAME: extension-builds
491-
# BLOB_NAME: ms-python-insiders.vsix
492-
493-
# steps:
494-
# - name: Download VSIX
495-
# uses: actions/download-artifact@v2
496-
# with:
497-
# name: ${{ env.ARTIFACT_NAME_VSIX }}
498-
499-
# - name: Azure Login
500-
# uses: azure/login@v1
501-
# with:
502-
# creds: ${{ secrets.AZURE_CREDENTIALS }}
503-
504-
# - name: Upload to Blob Storage
505-
# run: az storage blob upload --file ${{ env.VSIX_NAME }} --account-name pvsc --container-name ${{ env.BLOB_CONTAINER_NAME }} --name ${{ env.BLOB_NAME }} --auth-mode login
506-
507-
# - name: Get URL to uploaded VSIX
508-
# run: az storage blob url --account-name pvsc --container-name ${{ env.BLOB_CONTAINER_NAME }} --name ${{ env.BLOB_NAME }} --auth-mode login
482+
# name: Upload VSIX to Azure Blob Storage
483+
# runs-on: ubuntu-latest
484+
# if: github.repository == 'microsoft/vscode-python'
485+
# needs: [tests, smoke-tests, build-vsix]
486+
# env:
487+
# BLOB_CONTAINER_NAME: extension-builds
488+
# BLOB_NAME: ms-python-insiders.vsix
489+
# steps:
490+
# - name: Download VSIX
491+
# uses: actions/download-artifact@v2
492+
# with:
493+
# name: ${{ env.ARTIFACT_NAME_VSIX }}
494+
# - name: Azure Login
495+
# uses: azure/login@v1
496+
# with:
497+
# creds: ${{ secrets.AZURE_CREDENTIALS }}
498+
# - name: Upload to Blob Storage
499+
# run: az storage blob upload --file ${{ env.VSIX_NAME }} --account-name pvsc --container-name ${{ env.BLOB_CONTAINER_NAME }} --name ${{ env.BLOB_NAME }} --auth-mode login
500+
# - name: Get URL to uploaded VSIX
501+
# run: az storage blob url --account-name pvsc --container-name ${{ env.BLOB_CONTAINER_NAME }} --name ${{ env.BLOB_NAME }} --auth-mode login

.github/workflows/release.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ jobs:
117117
python-version: ${{matrix.python}}
118118

119119
- name: Use Node ${{env.NODE_VERSION}}
120-
uses: actions/setup-node@v2.1.1
120+
uses: actions/setup-node@v2
121121
with:
122122
node-version: ${{env.NODE_VERSION}}
123123

@@ -332,11 +332,10 @@ jobs:
332332
uses: azure/login@v1
333333
with:
334334
creds: ${{ secrets.AZURE_CREDENTIALS }}
335-
335+
336336
- name: Download JUPYTER VSIX
337337
run: az storage blob download --file ${{env.VSIX_NAME_JUPYTER}} --account-name pvsc --container-name extension-builds-jupyter --name ${{env.VSIX_NAME_JUPYTER}} --auth-mode login
338338

339-
340339
- name: Set CI_PYTHON_PATH and CI_DISABLE_AUTO_SELECTION
341340
run: |
342341
echo "CI_PYTHON_PATH=python" >> $GITHUB_ENV
@@ -398,11 +397,10 @@ jobs:
398397
uses: azure/login@v1
399398
with:
400399
creds: ${{ secrets.AZURE_CREDENTIALS }}
401-
400+
402401
- name: Download JUPYTER VSIX
403402
run: az storage blob download --file ${{env.VSIX_NAME_JUPYTER}} --account-name pvsc --container-name extension-builds-jupyter --name ${{env.VSIX_NAME_JUPYTER}} --auth-mode login
404403

405-
406404
- name: Set CI_PYTHON_PATH and CI_DISABLE_AUTO_SELECTION
407405
run: |
408406
echo "CI_PYTHON_PATH=python" >> $GITHUB_ENV
@@ -419,4 +417,4 @@ jobs:
419417
CODE_TESTS_WORKSPACE: ./src/testMultiRootWkspc/smokeTests
420418
uses: GabrielBB/[email protected]
421419
with:
422-
run: node --no-force-async-hooks-checks ./out/test/standardTest.js
420+
run: node --no-force-async-hooks-checks ./out/test/standardTest.js

0 commit comments

Comments
 (0)