Skip to content

Commit c8c4712

Browse files
authored
Wait for kernel to die instead of polling it (#11598)
1 parent afcf2a1 commit c8c4712

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pythonFiles/vscode_datascience_helpers/kernel_launcher_daemon.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,8 @@ def _read_stdout_in_background(self):
139139
sys.stdout.flush()
140140

141141
def _monitor_kernel(self):
142-
while self.kernel.poll(timeout=None) is None:
143-
pass
142+
self.log.warn("Waiting for Kernel to die %s", self.kernel.pid)
143+
self.kernel.wait(timeout=None)
144144

145145
exit_code = self.kernel.poll()
146146
std_err = self.kernel.stderr.read()

0 commit comments

Comments
 (0)