Fix code review comments

DonJayamanne · DonJayamanne · commit cf71a0a44fc4 · 2020-01-23T09:29:09.000-08:00
diff --git a/src/client/common/utils/misc.ts b/src/client/common/utils/misc.ts
@@ -53,7 +53,7 @@ export function isResource(resource?: InterpreterUri): resource is Resource {
 // tslint:disable-next-line: no-any
 export function isUri(resource?: Uri | any): resource is Uri {
     if (!resource) {
-        return true;
+        return false;
     }
     const uri = resource as Uri;
     return typeof uri.path === 'string' && typeof uri.scheme === 'string';

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ export function isResource(resource?: InterpreterUri): resource is Resource {`
`53`	`53`	`// tslint:disable-next-line: no-any`
`54`	`54`	`export function isUri(resource?: Uri \| any): resource is Uri {`
`55`	`55`	`if (!resource) {`
`56`		`- return true;`
	`56`	`+ return false;`
`57`	`57`	`}`
`58`	`58`	`const uri = resource as Uri;`
`59`	`59`	`return typeof uri.path === 'string' && typeof uri.scheme === 'string';`