Startup the jupyter server when appropriate (#9708)

* Preload server when appropriate

* Fix problem with startup of the server preventing the notebook editor from opening

* Fix build errors

* Fix DS dependency error occuring in master

* Review feedback

* Fix news file to have right setting

* Fix unit and functional tests.

* Address more code review comments

* Add unit test for server cache

* Add some more tracing

* Submit change for the different output file

* Fix smoke tests

* Fix linter

Author: rchiodo

news/1 Enhancements/7232.md

@@ -0,0 +1 @@
+Automatically start the Jupyter server when opening a notebook or the interative window, or when either of those has happened in the last 7 days. This behavior can be disabled with the 'python.dataScience.disableJupyterAutoStart' setting.

package.json

@@ -1804,6 +1804,12 @@
                     "description": "When debugging a cell, open this port on the remote box. If -1 is specified, a random port between 8889 and 9000 will be attempted.",
                     "scope": "resource"
                 },
+                "python.dataScience.disableJupyterAutoStart": {
+                    "type": "boolean",
+                    "default": false,
+                    "description": "When true, disables Jupyter from being automatically started for you. You must instead run a cell to start Jupyter.",
+                    "scope": "resource"
+                },
                 "python.dataScience.textOutputLimit": {
                     "type": "number",
                     "default": 20000,

src/client/common/asyncDisposableRegistry.ts

@@ -7,16 +7,20 @@ import { IAsyncDisposable, IAsyncDisposableRegistry, IDisposable } from './types
 // List of disposables that need to run a promise.
 @injectable()
 export class AsyncDisposableRegistry implements IAsyncDisposableRegistry {
-    private list: (IDisposable | IAsyncDisposable)[] = [];
+    private _list: (IDisposable | IAsyncDisposable)[] = [];
 
     public async dispose(): Promise<void> {
-        const promises = this.list.map(l => l.dispose());
+        const promises = this._list.map(l => l.dispose());
         await Promise.all(promises);
     }
 
     public push(disposable?: IDisposable | IAsyncDisposable) {
         if (disposable) {
-            this.list.push(disposable);
+            this._list.push(disposable);
         }
     }
+
+    public get list(): (IDisposable | IAsyncDisposable)[] {
+        return this._list;
+    }
 }

src/client/common/types.ts

@@ -396,6 +396,7 @@ export interface IDataScienceSettings {
     themeMatplotlibPlots?: boolean;
     useWebViewServer?: boolean;
     variableQueries: IVariableQuery[];
+    disableJupyterAutoStart?: boolean;
 }
 
 export const IConfigurationService = Symbol('IConfigurationService');