Skip to content

Commit d6b85df

Browse files
committed
Address code review comments
1 parent 159a47b commit d6b85df

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/client/common/process/pythonDaemon.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,9 @@ export class PythonDaemonExecutionService implements IPythonDaemonExecutionServi
5050
) {
5151
// tslint:disable-next-line: no-any
5252
this.connectionClosedDeferred = createDeferred<any>();
53-
// We don't want any unhandled exceptions from this promise.
54-
this.connectionClosedDeferred.promise.ignoreErrors();
53+
// This promise gets used conditionally, if it doesn't get used, and the promise is rejected,
54+
// then node logs errors. We don't want that, hence add a dummy error handler.
55+
this.connectionClosedDeferred.promise.catch(noop);
5556
this.monitorConnection();
5657
}
5758
public dispose() {

0 commit comments

Comments
 (0)