Clarify about the "vscode" flag in IocContainer.

Author: ericsnowcurrently

src/test/datascience/dataScienceIocContainer.ts

@@ -296,7 +296,7 @@ export class DataScienceIocContainer extends UnitTestIocContainer {
 
     constructor() {
         super();
-        this.vscode = false;
+        this.useVSCodeAPI = false;
         const isRollingBuild = process.env ? process.env.VSCODE_PYTHON_ROLLING !== undefined : false;
         this.shouldMockJupyter = !isRollingBuild;
         this.asyncRegistry = new AsyncDisposableRegistry();

src/test/serviceRegistry.ts

@@ -115,7 +115,11 @@ class LegacyFileSystem extends FileSystem {
 }
 
 export class IocContainer {
-    public vscode = true;
+    // This may be set (before any registration happens) to indicate
+    // whether or not IOC should depend on the VS Code API (e.g. the
+    // "vscode" module).  So in "functional" tests, this should be set
+    // to "false".
+    public useVSCodeAPI = true;
 
     public readonly serviceManager: IServiceManager;
     public readonly serviceContainer: IServiceContainer;
@@ -165,7 +169,7 @@ export class IocContainer {
         this.serviceManager.addSingleton<IPlatformService>(IPlatformService, PlatformService);
         this.serviceManager.addSingleton<IFileSystem>(
             IFileSystem,
-            this.vscode ? FileSystem : LegacyFileSystem
+            this.useVSCodeAPI ? FileSystem : LegacyFileSystem
         );
     }
     public registerProcessTypes() {