Skip to content

Commit e114152

Browse files
authored
Apply insiders space changes to release workflow (#14305)
1 parent c93bebf commit e114152

File tree

1 file changed

+20
-7
lines changed

1 file changed

+20
-7
lines changed

.github/workflows/release.yml

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,19 @@ jobs:
101101
name: Tests
102102
# The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded.
103103
runs-on: ${{ matrix.os }}
104+
env:
105+
# Something in Node 12.16.0 breaks the TS debug adapter, and ubuntu-latest bundles Node 12.16.1.
106+
# We can remove this when we switch over to the python-based DA in https://github.com/microsoft/vscode-python/issues/7136.
107+
# See https://github.com/microsoft/ptvsd/issues/2068
108+
# At this point pinning is only needed for consistency. We no longer have TS debug adapter.
109+
NODE_VERSION: 12.15.0
110+
# Force a path with spaces and to test extension works in these scenarios
111+
# Unicode characters are causing 2.7 failures so skip that for now.
112+
special-working-directory: './path with spaces'
113+
special-working-directory-relative: 'path with spaces'
114+
defaults:
115+
run:
116+
working-directory: ${{env.special-working-directory}}
104117
if: github.repository == 'microsoft/vscode-python'
105118
strategy:
106119
fail-fast: false
@@ -111,15 +124,11 @@ jobs:
111124
# Run the tests on the oldest and most recent versions of Python.
112125
python: [2.7, 3.8]
113126
test-suite: [ts-unit, python-unit, venv, single-workspace, multi-workspace, debugger, functional]
114-
env:
115-
# Something in Node 12.16.0 breaks the TS debug adapter, and ubuntu-latest bundles Node 12.16.1.
116-
# We can remove this when we switch over to the python-based DA in https://github.com/microsoft/vscode-python/issues/7136.
117-
# See https://github.com/microsoft/ptvsd/issues/2068
118-
# At this point pinning is only needed for consistency. We no longer have TS debug adapter.
119-
NODE_VERSION: 12.15.0
120127
steps:
121128
- name: Checkout
122129
uses: actions/checkout@v2
130+
with:
131+
path: ${{env.special-working-directory-relative}}
123132

124133
- name: Cache pip files
125134
uses: actions/cache@v2
@@ -138,7 +147,7 @@ jobs:
138147
id: out-cache
139148
uses: actions/cache@v2
140149
with:
141-
path: ./out
150+
path: ${{env.special-working-directory}}/out
142151
key: ${{runner.os}}-${{env.CACHE_OUT_DIRECTORY}}-${{hashFiles('src/**')}}
143152

144153
- name: Install dependencies (npm ci)
@@ -288,6 +297,7 @@ jobs:
288297
uses: GabrielBB/[email protected]
289298
with:
290299
run: npm run testSingleWorkspace
300+
working-directory: ${{env.special-working-directory}}
291301
if: matrix.test-suite == 'venv'
292302

293303
- name: Run single-workspace tests
@@ -296,6 +306,7 @@ jobs:
296306
uses: GabrielBB/[email protected]
297307
with:
298308
run: npm run testSingleWorkspace
309+
working-directory: ${{env.special-working-directory}}
299310
if: matrix.test-suite == 'single-workspace'
300311

301312
- name: Run multi-workspace tests
@@ -304,6 +315,7 @@ jobs:
304315
uses: GabrielBB/[email protected]
305316
with:
306317
run: npm run testMultiWorkspace
318+
working-directory: ${{env.special-working-directory}}
307319
if: matrix.test-suite == 'multi-workspace'
308320

309321
- name: Run debugger tests
@@ -312,6 +324,7 @@ jobs:
312324
uses: GabrielBB/[email protected]
313325
with:
314326
run: npm run testDebugger
327+
working-directory: ${{env.special-working-directory}}
315328
if: matrix.test-suite == 'debugger'
316329

317330
- name: Run functional tests

0 commit comments

Comments
 (0)