Skip to content

Commit e4358c1

Browse files
IanMatthewHuffIan Huff
andauthored
update testplan with docker instructions for mac / linux (#12940)
Co-authored-by: Ian Huff <[email protected]>
1 parent cb9ca25 commit e4358c1

File tree

1 file changed

+23
-17
lines changed

1 file changed

+23
-17
lines changed

.github/test_plan.md

Lines changed: 23 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -576,23 +576,29 @@ def test_failure():
576576
1. Run a cell on the host
577577
1. Verify the editor opens on the guest and the cell is run there too
578578
- [ ] Jupyter Hub support
579-
1. Install Docker Desktop onto a machine
580-
1. Create a folder with a file 'Dockerfile' in it.
581-
1. Mark the file to look like so:
582-
583-
```
584-
ARG BASE_CONTAINER=jupyterhub/jupyterhub
585-
FROM $BASE_CONTAINER
586-
587-
USER root
588-
589-
USER $NB_UID
590-
```
591-
592-
1. From a command prompt (in the same folder as the Dockerfile), run ```docker build -t jupyterhubcontainer:1.0 .```
593-
1. Run ```docker container create --name jupyterhub jupyterhubcontainer:1.0 jupyterhub```
594-
1. From the docker desktop app, start the jupyterhub container.
595-
1. From the docker desktop app, run the CLI
579+
1. Windows install instructions
580+
1. Install Docker Desktop onto a machine
581+
1. Create a folder with a file 'Dockerfile' in it.
582+
1. Mark the file to look like so:
583+
584+
```
585+
ARG BASE_CONTAINER=jupyterhub/jupyterhub
586+
FROM $BASE_CONTAINER
587+
588+
USER root
589+
590+
USER $NB_UID
591+
```
592+
593+
1. From a command prompt (in the same folder as the Dockerfile), run ```docker build -t jupyterhubcontainer:1.0 .```
594+
1. Run ```docker container create --name jupyterhub jupyterhubcontainer:1.0 jupyterhub```
595+
1. From the docker desktop app, start the jupyterhub container.
596+
1. From the docker desktop app, run the CLI
597+
1. OR Mac / Linux install instructions
598+
1. Install docker
599+
1. From the terminal ```docker run -p 8000:8000 -d --name jupyterhub jupyterhub/jupyterhub jupyterhub```
600+
1. Open a terminal in the docker container with ```docker exec -it jupyterhub bash```
601+
1. From that terminal run ```python3 -m pip install notebook```
596602
1. From the new command prompt, run ```adduser testuser```
597603
1. Follow the series of prompts to add a password for this user
598604
1. Open VS code

0 commit comments

Comments
 (0)