Skip to content

Commit e5ba13f

Browse files
authored
Skip venv tests for 2.7 and disable fail fast (#11546)
* Skip venv tests for 2.7 and disable fail fast * Use isPythonVersion * Remove CI_PYTHON_VERSION env setting * Revert "Remove CI_PYTHON_VERSION env setting" This reverts commit d7c7567. * Revert "Use isPythonVersion" This reverts commit 06f3a81.
1 parent c440a23 commit e5ba13f

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,7 @@ jobs:
383383
- name: Run venv tests
384384
env:
385385
TEST_FILES_SUFFIX: testvirtualenvs
386+
CI_PYTHON_VERSION: ${{matrix.python}}
386387
uses: GabrielBB/[email protected]
387388
with:
388389
run: npm run testSingleWorkspace

src/test/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,11 @@ suite('Activation of Environments in Terminal', () => {
171171
expect(fileSystem.arePathsSame(content, PYTHON_PATH)).to.equal(false, 'Environment not activated');
172172
});
173173

174-
test('Should activate with venv', async () => {
174+
test('Should activate with venv', async function () {
175+
if (process.env.CI_PYTHON_VERSION && process.env.CI_PYTHON_VERSION.startsWith('2.')) {
176+
// tslint:disable-next-line: no-invalid-this
177+
this.skip();
178+
}
175179
await testActivation(envPaths.venvPath);
176180
});
177181
test('Should activate with pipenv', async () => {

0 commit comments

Comments
 (0)