Skip to content

Commit fa0e613

Browse files
committed
Include interperter name in message (#10174)
For #10071 Fix to ensure interpreter is included in message, here's the actual message seen by the user. Error: Jupyter cannot be started. Error attempting to locate jupyter: 'Kernelspec' module not installed in the selected interpreter ({0}). Note the {0}
1 parent 0f0065b commit fa0e613

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/client/datascience/jupyter/interpreter/jupyterInterpreterSubCommandExecutionService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export class JupyterInterpreterSubCommandExecutionService implements IJupyterSub
8383
}
8484

8585
if (productsNotInstalled.length === 1 && productsNotInstalled[0] === Product.kernelspec) {
86-
return DataScience.jupyterKernelSpecModuleNotFound();
86+
return DataScience.jupyterKernelSpecModuleNotFound().format(interpreter.path);
8787
}
8888

8989
return getMessageForLibrariesNotInstalled(productsNotInstalled, interpreter.displayName);

src/test/datascience/jupyter/interpreter/jupyterInterpreterSubCommandExecutionService.unit.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ suite('Data Science - Jupyter InterpreterSubCommandExecutionService', () => {
223223

224224
const reason = await jupyterInterpreterExecutionService.getReasonForJupyterNotebookNotBeingSupported(undefined);
225225

226-
assert.equal(reason, DataScience.jupyterKernelSpecModuleNotFound());
226+
assert.equal(reason, DataScience.jupyterKernelSpecModuleNotFound().format(selectedJupyterInterpreter.path));
227227
});
228228
test('Can start jupyer notebook', async () => {
229229
const output = await jupyterInterpreterExecutionService.startNotebook([], {});

0 commit comments

Comments
 (0)