Skip to content

Fixes to ds custom editor #10257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

DonJayamanne
Copy link

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

Merging #10257 into ds/custom_editor will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##           ds/custom_editor   #10257   +/-   ##
=================================================
  Coverage             60.83%   60.83%           
=================================================
  Files                   567      567           
  Lines                 30586    30586           
  Branches               4363     4363           
=================================================
  Hits                  18608    18608           
  Misses                11031    11031           
  Partials                947      947
Impacted Files Coverage Δ
src/client/telemetry/index.ts 87.38% <ø> (ø) ⬆️
...ascience/interactive-ipynb/nativeEditorProvider.ts 51.92% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca10f93...3b838da. Read the comment docs.

@DonJayamanne
Copy link
Author

Doesn't fix all tests, but fixes a few of them

@DonJayamanne DonJayamanne merged commit c7f6ed0 into microsoft:ds/custom_editor Feb 21, 2020
@DonJayamanne DonJayamanne deleted the fixTestsFS branch February 21, 2020 22:38
@lock lock bot locked as resolved and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants