Jupyter autocompletion will only show up on empty lines, #10420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of appearing in functions.
DavidKutu
commented
Mar 3, 2020
src/client/datascience/interactive-common/intellisense/intellisenseProvider.ts
Outdated
Show resolved
Hide resolved
rchiodo
reviewed
Mar 3, 2020
src/client/datascience/interactive-common/intellisense/intellisenseProvider.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #10420 +/- ##
==========================================
- Coverage 60.84% 60.83% -0.02%
==========================================
Files 570 579 +9
Lines 30720 31300 +580
Branches 4376 4451 +75
==========================================
+ Hits 18691 19040 +349
- Misses 11078 11295 +217
- Partials 951 965 +14
Continue to review full report at Codecov.
|
ignoring all the jupyter intellisense.
DonJayamanne
requested changes
Mar 4, 2020
src/client/datascience/interactive-common/intellisense/intellisenseProvider.ts
Outdated
Show resolved
Hide resolved
IanMatthewHuff
requested changes
Mar 10, 2020
DonJayamanne
requested changes
Mar 10, 2020
| @@ -502,6 +502,21 @@ export class IntellisenseProvider implements IInteractiveWindowListener { | |||
| }; | |||
| } | |||
|
|
|||
| private filterJupyterMatches( | |||
There was a problem hiding this comment.
Not sure what this method does. sounds very generic.
Please could you add comments about what this method does
IanMatthewHuff
approved these changes
Mar 10, 2020
DonJayamanne
approved these changes
Mar 10, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
added a commit
that referenced
this pull request
Mar 13, 2020
* master: Fix flakey file system tests (#10541) Tweaks for gather (#10532) Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517) Add conda support to nightly flake test (#10523) Rename datascience to datascience_modules (#10525) Clean up the extension activation code. (#10455) Allow escape and ctrl+U to clear the interactive window (#10513) Fix builtins so they don't interfere with our execution (#10511) Jupyter autocompletion will only show up on empty lines, (#10420) notify on missing kernel and interpreter with kernel (#10508)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of appearing in functions.
For #10023
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).