Skip to content

Tweaks for gather #10532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/webpack/webpack.extension.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const config = {
},
// Packages listed in externals keeps webpack from trying to package them.
// The ppaPackageList variable is set to non-empty if the build pipeline has been
//authenticated to install @msrvida/python-program-analysis.
// authenticated to install @msrvida/python-program-analysis.
externals: ['vscode', 'commonjs', ...ppaPackageList, ...existingModulesInOutDir],
plugins: [
...common.getDefaultPlugins('extension'),
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1832,14 +1832,14 @@
},
"python.dataScience.enableGather": {
"type": "boolean",
"default": false,
"description": "Enable experimental code gathering for executed cells. For a gathered cell, that cell and only the code it depends on will be exported to a new notebook.",
"default": true,
"description": "Python Insiders Only: Enable experimental gather feature for executed cells. For a gathered cell, that cell and only the code it depends on will be exported to a new notebook.",
"scope": "resource"
},
"python.dataScience.gatherToScript": {
"type": "boolean",
"default": true,
"description": "If experimental code gather is enabled, gather code to a python script rather than a notebook.",
"default": false,
"description": "Python Insiders Only: If experimental gather feature is enabled, gather code to a python script rather than a notebook.",
"scope": "resource"
},
"python.dataScience.codeLenses": {
Expand Down
1 change: 1 addition & 0 deletions src/client/datascience/gather/gather.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export class GatherProvider implements IGatherProvider {
@inject(IDisposableRegistry) private disposables: IDisposableRegistry,
@inject(ICommandManager) private commandManager: ICommandManager
) {
// Disable gather if we're not running on insiders.
this._enabled =
this.configService.getSettings().datascience.enableGather &&
this.configService.getSettings().insidersChannel !== 'off'
Expand Down
13 changes: 11 additions & 2 deletions src/datascience-ui/react-common/images/GatherCode/gather_dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 12 additions & 2 deletions src/datascience-ui/react-common/images/GatherCode/gather_light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.