use only resource on kernel launcher #11339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and instead use ignoreErrors
python interpreter, only a resource uri
DavidKutu
requested review from
DonJayamanne,
greazer,
IanMatthewHuff and
rchiodo
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
||
| if (kernelSpec) { | ||
| // tslint:disable-next-line: no-floating-promises | ||
| this.writeCache(this.cache); | ||
| this.writeCache(this.cache).ignoreErrors(); |
IanMatthewHuff
approved these changes
Apr 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #11339 +/- ##
==========================================
- Coverage 61.05% 60.98% -0.08%
==========================================
Files 604 606 +2
Lines 33421 33448 +27
Branches 4732 4730 -2
==========================================
- Hits 20405 20398 -7
- Misses 12575 12605 +30
- Partials 441 445 +4
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11314
Also, I removed the comment to disable tslint and used ignoreErrors
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).