make sure we use our resource to get interpreter details #11474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanMatthewHuff
commented
Apr 28, 2020
| @@ -76,7 +76,7 @@ export class PythonExecutionFactory implements IPythonExecutionFactory { | |||
| const interpreterService = this.serviceContainer.get<IInterpreterService>(IInterpreterService); | |||
| const logger = this.serviceContainer.get<IProcessLogger>(IProcessLogger); | |||
|
|
|||
| const interpreter = await interpreterService.getInterpreterDetails(pythonPath); | |||
| const interpreter = await interpreterService.getInterpreterDetails(pythonPath, options.resource); | |||
There was a problem hiding this comment.
Per discussion on teams I think this is the change we need. This should cover cases where the full pythonPath is specified in the spec, and if it's just "python" it will use the resource to calculate the interpreter.
IanMatthewHuff
requested review from
DonJayamanne,
DavidKutu,
greazer and
rchiodo
IanMatthewHuff
commented
Apr 28, 2020
DonJayamanne
approved these changes
Apr 28, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
DavidKutu
approved these changes
Apr 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #11474 +/- ##
==========================================
- Coverage 60.61% 60.60% -0.02%
==========================================
Files 612 612
Lines 33472 33472
Branches 4719 4719
==========================================
- Hits 20290 20285 -5
- Misses 12731 12735 +4
- Partials 451 452 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11469
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).