Skip to content

Use full path in argv to find interpreter matching a kernel #11478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Apr 28, 2020

If we have a kernel spec with fully qualified path in argv (for python2 or 3), then we don't end up finding a matching interpreter, this ensures we find the interpreter.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Apr 28, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.9% 0.9% Duplication

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne changed the title Use qualified path in argv to find interpreter matching a kernel Use full path in argv to find interpreter matching a kernel Apr 28, 2020
@DonJayamanne DonJayamanne merged commit 223fd77 into microsoft:master Apr 28, 2020
@DonJayamanne DonJayamanne deleted the findMatchingInterpreter branch April 28, 2020 21:29
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants