forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Skip venv tests for 2.7 and disable fail fast #11546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
98a3e81
Skip venv tests for 2.7 and disable fail fast
karthiknadig 06f3a81
Use isPythonVersion
karthiknadig d7c7567
Remove CI_PYTHON_VERSION env setting
karthiknadig 820ea8a
Revert "Remove CI_PYTHON_VERSION env setting"
karthiknadig ab6480e
Revert "Use isPythonVersion"
karthiknadig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -195,6 +195,7 @@ jobs: | |
if: github.repository == 'microsoft/vscode-python' | ||
needs: [python-deps, js-ts-deps] | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
# We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used, | ||
# macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case. | ||
|
@@ -381,6 +382,7 @@ jobs: | |
- name: Run venv tests | ||
env: | ||
TEST_FILES_SUFFIX: testvirtualenvs | ||
CI_PYTHON_VERSION: ${{matrix.python}} | ||
uses: GabrielBB/[email protected] | ||
with: | ||
run: npm run testSingleWorkspace | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.