Skip to content

Skip venv tests for 2.7 and disable fail fast #11546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ jobs:
if: github.repository == 'microsoft/vscode-python'
needs: [python-deps, js-ts-deps]
strategy:
fail-fast: false
matrix:
# We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used,
# macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case.
Expand Down Expand Up @@ -381,6 +382,7 @@ jobs:
- name: Run venv tests
env:
TEST_FILES_SUFFIX: testvirtualenvs
CI_PYTHON_VERSION: ${{matrix.python}}
uses: GabrielBB/[email protected]
with:
run: npm run testSingleWorkspace
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,11 @@ suite('Activation of Environments in Terminal', () => {
expect(fileSystem.arePathsSame(content, PYTHON_PATH)).to.equal(false, 'Environment not activated');
});

test('Should activate with venv', async () => {
test('Should activate with venv', async function () {
if (process.env.CI_PYTHON_VERSION && process.env.CI_PYTHON_VERSION.startsWith('2.')) {
// tslint:disable-next-line: no-invalid-this
this.skip();
}
await testActivation(envPaths.venvPath);
});
test('Should activate with pipenv', async () => {
Expand Down