Fix the variable based tests to search for the appropriate values #12197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
requested review from
IanMatthewHuff,
DonJayamanne,
greazer,
DavidKutu,
joyceerhl and
techwithtim
| const Type_Column = Name_Column + 1; | ||
| const Shape_Column = Type_Column + 1; | ||
| const Value_Column = Shape_Column + 1; | ||
| const Button_Column = 0; |
There was a problem hiding this comment.
const Button_Column = 0;
const Name_Column = Button_Column + 1;
const Type_Column = Name_Column + 1;
const Shape_Column = Type_Column + 1;
const Value_Column = Shape_Column + 1;
Maybe? Just makes it match the actual layout.
IanMatthewHuff
approved these changes
Jun 8, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
DavidKutu
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dev.azure.com/ms/vscode-python/_build/results?buildId=86218&view=ms.vss-test-web.build-test-results-tab&runId=2412888&resultId=100384&paneView=debug
Recent changes to the variable explorer broke the tests.