Skip to content

Fix nightly data science IOC container and fix service spelling #12810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 8, 2020
Merged

Fix nightly data science IOC container and fix service spelling #12810

merged 7 commits into from
Jul 8, 2020

Conversation

IanMatthewHuff
Copy link
Member

For #12809

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff
Copy link
Member Author

Shoot, I wasn't paying enough attention on this. I think that I needed to add these in a different way. Will edit.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IanMatthewHuff IanMatthewHuff merged commit 01e6cf1 into microsoft:master Jul 8, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/fixNightlyTestIOC branch July 8, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@rchiodo rchiodo rchiodo approved these changes

@greazer greazer Awaiting requested review from greazer

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

@joyceerhl joyceerhl Awaiting requested review from joyceerhl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IanMatthewHuff @DonJayamanne @rchiodo