Skip to content

Disable flakey JupyterServerUriProvider test #13669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IanMatthewHuff
Copy link
Member

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2020

Codecov Report

Merging #13669 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13669      +/-   ##
==========================================
- Coverage   59.79%   59.70%   -0.09%     
==========================================
  Files         670      674       +4     
  Lines       37514    37667     +153     
  Branches     5387     5404      +17     
==========================================
+ Hits        22430    22490      +60     
- Misses      13921    14007      +86     
- Partials     1163     1170       +7     
Impacted Files Coverage Δ
src/client/common/errors/errorUtils.ts 50.00% <0.00%> (-37.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/jupyter/notebookStarter.ts 64.95% <0.00%> (-1.71%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/datascience/types.ts 100.00% <0.00%> (ø)
src/client/datascience/common.ts 58.66% <0.00%> (ø)
src/client/pythonEnvironments/legacyIOC.ts 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37c79d...47d6b73. Read the comment docs.

@IanMatthewHuff
Copy link
Member Author

Push over Mac failure as this is just a test disable.

@IanMatthewHuff IanMatthewHuff merged commit 6b9884e into microsoft:master Aug 28, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/disableFlakeTest branch August 28, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants