Skip to content

Mark some of the metadata as transient #13723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

DonJayamanne
Copy link

For #13661
Mark some metadata as transient, meaning they do not contribute to file changes (git)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #13723 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13723      +/-   ##
==========================================
- Coverage   59.82%   59.80%   -0.03%     
==========================================
  Files         675      675              
  Lines       37796    37796              
  Branches     5445     5445              
==========================================
- Hits        22612    22604       -8     
+ Misses      14026    14017       -9     
- Partials     1158     1175      +17     
Impacted Files Coverage Δ
src/client/common/application/notebook.ts 10.90% <0.00%> (ø)
src/client/common/application/types.ts 100.00% <ø> (ø)
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/common/utils/platform.ts 56.00% <0.00%> (-4.00%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/logging/levels.ts 61.11% <0.00%> (ø)
src/client/logging/logger.ts 62.74% <0.00%> (ø)
src/client/logging/formatters.ts 53.57% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc10b9...f9526da. Read the comment docs.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Sep 1, 2020
@DonJayamanne DonJayamanne merged commit 761242a into microsoft:master Sep 1, 2020
@DonJayamanne DonJayamanne deleted the issue13661Transient branch September 1, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants