Update other cells in cell execution #14240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
force-pushed
the
updateDisplayIdInCellExecution
branch
from
2f15899 to
52ddfbd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #14240 +/- ##
=======================================
Coverage 59.95% 59.96%
=======================================
Files 706 706
Lines 39183 39179 -4
Branches 5681 5681
=======================================
- Hits 23493 23492 -1
+ Misses 14453 14450 -3
Partials 1237 1237
Continue to review full report at Codecov.
|
DonJayamanne
requested review from
rchiodo,
DavidKutu,
greazer,
IanMatthewHuff and
joyceerhl
rchiodo
approved these changes
Oct 2, 2020
DonJayamanne
added a commit
that referenced
this pull request
Oct 30, 2020
* Remove cell index property and use build in prop (#14239) * Update other cells in cell execution (#14240) * Tests for prompting to install missing ipykernel (#14266) * Treat Native notebook tests as VS Code tests (#14282) * Fixes to blowing away of kernel info & not using right startup info (… … * Default cell language for native notebooks (#14314) * Ignore formatting in ipynb when dealing with trust (#14333) * Fixes to trust service (#14352) * Change `IPython kernel` to `Jupyter kernel` (#14375) * Trust for native notebooks (#14353)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current when we need to update output of another cell when using IPython.display, it doesnt work properly with native notebooks.
THis is because we await in cellExecution class for updates to the cells.
While the above updates are pending, the IOPub messages from kernel are handled elsewhere and we update other cells, hence we have multiple updates going on and in parallel. This results in output not getting displayed.
Moved the code to listen to iopub messages & handle display updates to the cell execution (we were already listening to those messages, just had to move the code to perform the updates).
Also found that the onIoPubMessage was not use anywhere else, hence removed it