Skip to content

Change IPython kernel to Jupyter kernel #14375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

DonJayamanne
Copy link

For #14309

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@0f0dec9). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #14375   +/-   ##
=======================================
  Coverage        ?   59.42%           
=======================================
  Files           ?      716           
  Lines           ?    39955           
  Branches        ?     5789           
=======================================
  Hits            ?    23742           
  Misses          ?    14953           
  Partials        ?     1260           
Impacted Files Coverage Δ
src/client/common/utils/localize.ts 96.25% <100.00%> (ø)
src/client/typeFormatters/blockFormatProvider.ts 11.53% <0.00%> (ø)
...very/locators/services/virtualenvwrapperLocator.ts 76.92% <0.00%> (ø)
...n/terminal/shellDetectors/settingsShellDetector.ts 96.96% <0.00%> (ø)
src/client/common/process/logger.ts 91.30% <0.00%> (ø)
...er/extension/configuration/providers/fileLaunch.ts 100.00% <0.00%> (ø)
src/client/datascience/liveshare/serviceProxy.ts 5.88% <0.00%> (ø)
...tension/configuration/debugConfigurationService.ts 78.94% <0.00%> (ø)
...lient/datascience/notebookStorage/notebookModel.ts 46.89% <0.00%> (ø)
src/client/terminals/codeExecution/repl.ts 100.00% <0.00%> (ø)
... and 707 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0dec9...d272c45. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 5583df4 into microsoft:main Oct 12, 2020
@DonJayamanne DonJayamanne deleted the issue14309 branch October 12, 2020 19:35
luabud pushed a commit to luabud/vscode-python that referenced this pull request Oct 26, 2020
DonJayamanne added a commit that referenced this pull request Oct 30, 2020
* Remove cell index property and use build in prop (#14239)
* Update other cells in cell execution (#14240)
* Tests for prompting to install missing ipykernel (#14266)
* Treat Native notebook tests as VS Code tests (#14282)
* Fixes to blowing away of kernel info & not using right startup info (… …
* Default cell language for native notebooks (#14314)
* Ignore formatting in ipynb when dealing with trust (#14333)
* Fixes to trust service (#14352)
* Change `IPython kernel` to `Jupyter kernel` (#14375)
* Trust for native notebooks (#14353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants