Skip to content

Fix code coverage upload #14821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 25, 2020
Merged

Conversation

kimadeline
Copy link

@kimadeline kimadeline commented Nov 25, 2020

For #14815

Insiders upload:

⚠️ PR check upload: We don't do that unless we're on microsoft/vscode-python, do we want want to change this for code coverage to be uploaded for all PRs?

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Nov 25, 2020
@kimadeline kimadeline marked this pull request as ready for review November 25, 2020 16:40
@codecov-io
Copy link

codecov-io commented Nov 25, 2020

Codecov Report

Merging #14821 (568ecc7) into main (e1cc8b2) will increase coverage by 0%.
The diff coverage is 82%.

@@           Coverage Diff           @@
##            main   #14821    +/-   ##
=======================================
  Coverage     64%      65%            
=======================================
  Files        547      550     +3     
  Lines      25616    25916   +300     
  Branches    3619     3673    +54     
=======================================
+ Hits       16622    16871   +249     
- Misses      8314     8352    +38     
- Partials     680      693    +13     
Impacted Files Coverage Δ
...tension/configuration/debugConfigurationService.ts 71% <0%> (-8%) ⬇️
...c/client/debugger/extension/configuration/types.ts 100% <ø> (ø)
src/client/debugger/types.ts 100% <ø> (ø)
.../jupyter/languageserver/notebookMiddlewareAddon.ts 3% <0%> (ø)
src/client/pythonEnvironments/index.ts 25% <ø> (ø)
src/client/telemetry/index.ts 78% <ø> (ø)
...lient/pythonEnvironments/common/windowsRegistry.ts 23% <23%> (ø)
...rc/client/activation/jedi/multiplexingActivator.ts 18% <50%> (+<1%) ⬆️
src/client/common/platform/fileSystemWatcher.ts 22% <50%> (ø)
...nments/base/locators/lowLevel/fsWatchingLocator.ts 75% <50%> (ø)
... and 44 more

Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tweak to pull in prior to merge, but otherwise LGTM!

@kimadeline kimadeline merged commit f9838bf into microsoft:main Nov 25, 2020
@kimadeline kimadeline deleted the 14815-code-coverage-upload branch November 25, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants